Clean up css in File

test in http://csslint.net found two warnings attach is the patch i have created and tested locally, nothing was broken.

+++ b/core/modules/file/file.admin.cssundefined
@@ -21,6 +21,6 @@
+.form-managed-file div.ajax-progress-bar .bar {

div.ajax-progress-bar

hi droplet add a new patch but question why on csslint it has only two warnings? and what you have said on comment no.4 is not a warning or error on css lint?

I scanned with my eyes. and I just tested following code and shows me 2 warnings.

form-managed-file div.ajax-progress-bar div.bar {
margin: 0;
}

when there is 2 styles, csslint thinks this is indeed needed

.form-managed-file div.ajax-progress-bar {
   display: none;
   margin-top: 4px;
   padding: 0;
   width: 28em;
 }
.form-managed-file div.ajax-progress-bar .bar {
   margin: 0;
 }

Hehe, #1190252 haven't talking it deeply before this mission.

(even it leaves, HTML5 Clean up will remove it i think.)

#5: file-css-clean-up-1662990-5.patch queued for re-testing.

Wrong component

Everything OK, applies cleanly.

CSS changes need manual testing in all browsers and all affected core themes:

1. Test pages where the relevant classes are used without the patch applied.
2. Apply the patch, clear the site and browser caches, and test again. Confirm that there are no changes or regressions.

Post before-and-after screenshots for one browser/theme.

It's unclear to me where these classes are being applied. Could someone with better knowledge of the File module point out exactly what a tester should be looking for in this case?

#5 applies well in Firefox, Chrome & IE8.
Will be needed to check the .ajax-progress-bar.

@joedougherty They're added on the file upload boxes in content add/edit screens

Also tested against latest build of Drupal 8, patch in #5 applies fine. Looks great in all Mac browsers and Lint returns 0 errors :)

Removed 2 overqualified elements in file.admin.css as recommended by csslint

Also worked in Safari for Windows, didn't attach screenshot.

@daniel92

Removed 2 overqualified elements in file.admin.css as recommended by csslint

does that mean you made a change to the code and then took the screenshots? (great screenshots!!!!)

The left screenshot for each browser is before I changed the code, and the right screenshot for each browser is after I changed the code to prove that it didn't break anything.

Thankyou!!

OH, I see, one of the files attached was a patch! sorry, I guess I thought there were two jpgs or something.

changing status to needs review so the testbot has a look at your patch.

how is this different than the previous patch in #5? maybe an interdiff would help... but also maybe just #5 does not apply anymore.

Rerolled patch.

Tested and it gives the same results as #18 <-- Logically, because the changed code is exactly the same!!
The diffence between #18 patch and #24 patch is all about tabs and standard coding hence did not pass the test.

Without doubt, it can be set as reviewed.

Committed/pushed to 8.x, thanks!