Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
locale.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 Jun 2012 at 18:14 UTC
Updated:
17 Feb 2017 at 09:55 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
droplet commentedabbr.ajax-changed is a globally issue to every AJAX-change.
Comment #2
robloachAfter applying the patch....
rob@Computron /var/www/drupal/8 $ node ../../csslint/release/npm/cli.js core/modules/locale/
csslint: No errors in core/modules/locale//locale.admin-rtl.css.
csslint: There are 11 problems in core/modules/locale//locale.admin.css.
locale.admin.css
1: warning at line 5, col 3
Using width with padding-right can sometimes make elements larger than you expect.
padding-right: 1em; /* LTR */
locale.admin.css
2: warning at line 19, col 22
Values of 0 shouldn't have units specified.
padding: 3.5ex 0 0 0em; /* LTR */
locale.admin.css
3: warning at line 21, col 1
Don't use IDs in selectors.
#locale-translate-edit-form th{
locale.admin.css
4: warning at line 25, col 1
Don't use IDs in selectors.
#locale-translate-edit-form .form-item{
locale.admin.css
5: warning at line 28, col 1
Don't use IDs in selectors.
#locale-translate-edit-form td {
locale.admin.css
6: warning at line 32, col 1
Don't use IDs in selectors.
#locale-translate-edit-form .changed {
locale.admin.css
7: warning at line 36, col 1
Don't use IDs in selectors.
#locale-translate-edit-form .form-type-item abbr.ajax-changed {
locale.admin.css
8: warning at line 36, col 45
Element (abbr.ajax-changed) is overqualified, just use .ajax-changed without element name.
#locale-translate-edit-form .form-type-item abbr.ajax-changed {
locale.admin.css
9: warning at line 44, col 1
2 IDs in the selector, really?
#locale-translate-edit-form #edit-strings .locale-translate-edit-table {
locale.admin.css
10: warning at line 48, col 43
Don't use adjoining classes.
#locale-translate-edit-form #edit-strings .locale-translate-edit-table.changed {
locale.admin.css
11: warning at line 48, col 1
2 IDs in the selector, really?
#locale-translate-edit-form #edit-strings .locale-translate-edit-table.changed {
Comment #3
droplet commentedSeems like I uploaded a wrong patch.
Comment #4
robloachrob@Computron /var/www/drupal/8 $ node ../../csslint/release/npm/cli.js core/modules/locale/
csslint: No errors in core/modules/locale//locale-rtl.css.
csslint: No errors in core/modules/locale//locale.admin-rtl.css.
csslint: No errors in core/modules/locale//locale.admin.css.
Comment #5
droplet commentedno position: absolute; for following message
"* Changes made in this table will not be saved until the form is submitted."
Comment #6
droplet commentedmy editor su*
Comment #7
star-szrJust created #1799124: locale-rtl.css is out of sync with locale.admin.css, is never included due to incorrect filename which is related to this issue.
Comment #8
risse commented#6: locale2.patch queued for re-testing.
Comment #10
risse commentedUpdated patch to work with latest dev.
locale.admin.css = CSS lint found 0 errors and 0 warnings.
locale.rtl.css = CSS lint found 0 errors and 0 warnings.
Comment #11
risse commentedComment #13
risse commentedWell, that was a stupid mistake. New try!
Comment #14
barrapontoWonderful, works as expected. Just added spaces before
{to meet css styles.Comment #15
xjmCSS changes need manual testing in all browsers and all affected core themes:
Post before-and-after screenshots for one browser/theme.
Comment #16
xjmComment #17
dnotes commentedI've confirmed that there are no changes. Screenshots attached. Setting back to RTBC since manual testing is done.
Comment #18
xjmThanks @dnotes!
Comment #19
webchickAwesome work! Committed and pushed to 8.x. :)
Comment #21
frederickjhRemoving Needs screenshots tag. Marked Closed. Issue queue cleanup for those searching for issues needing screenshots.