Clean up css in openid

Changed ids into classes and in .css .js files.
And there is still problem with duplicate background image.

The javascript does not need to be altered in relation to this issue at all. Also, the html related to the selectors that has to been changed need to have the new classes added. The patch only updated the css.

re-tagging. Meant to to select needs work in #2.

tlattimore, I grepped all code for ids and they were found only in css and js files of a module.
How to find html related to css ids if grep found only this:

Igors-Mac-Pro:drupal iflista$ grep -r '#edit-openid-identifier' *
core/modules/openid/openid-rtl.css:#edit-openid-identifier {
core/modules/openid/openid.css:#edit-openid-identifier {
core/modules/openid/openid.js:      var $edit_openid_identifier = $('#edit-openid-identifier');
core/modules/openid/openid.js:        $('#edit-openid-identifier')[0].focus();
core/modules/openid/openid.js:        $('#edit-openid-identifier').val('').removeClass('error');

Thanks.

I try css way to do this clean up.

#5: openid-csslint-1663140-5.patch queued for re-testing.

Why this patch doesn't pass the testing ?

The patch is old, and a lot has happened in core since then. You (or somebody else) need to create a fresh version of the patch.

I've written the patch all over again, making the item list openid-link more reusable and cleaning up everything else but the double declaration of background-image. but as I see it, they're two completely different widgets, with no sprite usage (or need). So I think this is enough.

-#block-user-login #openid-login-form {
+.user-login-form + .openid-login-form {

This seems a bit fragile, e.g. if some theme wraps form elements in divs. What do you think of .block-user .openid-login-form { instead?

@c960657 it's better, although it ties openid-login-form to user module blocks :/

No it doesn't. In fact, the form is also used on its own on user/login/openid. However, the mentioned rule is specific to the toggle mechanism used in the user block. If we want to untie this connection, we need to change the JavaScript and PHP code also, not just the CSS.

This is no longer a Drupal core issue as it has been moved to contrib - see #556380: Remove OpenID from core