Closed (works as designed)
Project:
Drupal core
Version:
5.2
Component:
comment.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Aug 2007 at 21:38 UTC
Updated:
13 Sep 2007 at 17:11 UTC
Per this note about how 5.x handles t(), it looks like theme_comment should use the ! markup for the username instead of %.
Line 1778:
$output .= '<div class="credit">'. t('by %a on %b', array('%a' => theme('username', $comment), '%b' => format_date($comment->timestamp))) ."</div>\n";
...should change to:
$output .= '<div class="credit">'. t('by !a on %b', array('!a' => theme('username', $comment), '%b' => format_date($comment->timestamp))) ."</div>\n";
Comments
Comment #1
dvessel commentedIt depends on what it's outputting. ! vs. % are treated differently. Doesn't look like % is wrong.
http://api.drupal.org/api/function/t/5
Comment #2
hunthunthunt commentedI agree with drumdance.
When trying to theme theme_comment() with the original code, the output is buggy.