Per this note about how 5.x handles t(), it looks like theme_comment should use the ! markup for the username instead of %.

Line 1778:

$output .= '<div class="credit">'. t('by %a on %b', array('%a' => theme('username', $comment), '%b' => format_date($comment->timestamp))) ."</div>\n"; 

...should change to:

$output .= '<div class="credit">'. t('by !a on %b', array('!a' => theme('username', $comment), '%b' => format_date($comment->timestamp))) ."</div>\n"; 

Comments

dvessel’s picture

Status: Active » Closed (works as designed)

It depends on what it's outputting. ! vs. % are treated differently. Doesn't look like % is wrong.

http://api.drupal.org/api/function/t/5

hunthunthunt’s picture

I agree with drumdance.

When trying to theme theme_comment() with the original code, the output is buggy.