[D6] uc_correios_webservices

Hello and Welcome,

thanks for the module. There are some issues:

Git:
Your git clone command is off, use: git clone http://git.drupal.org/sandbox/rodrigoprior/1651150.git uc_correios_webservices

Master Branch:
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Automatic review of the master branch:
PAReview shows a lot of errors: http://ventral.org/pareview/httpgitdrupalorgsandboxrodrigoprior1651150git

Please check Drupal coding standards. You can use the online version of PAReview to check your project.

Re-opening this application, closing #1707028: [D6] uc_correios_webservices and #1788304: [D6] uc_correios_webservices as duplicates.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Hi,

Still the code have some issue.

Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: ...all/modules/pareview_temp/test_candidate/uc_correios_webservices.module
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------
355 | ERROR | Line indented incorrectly; expected 6 spaces, found 4
356 | ERROR | break statement indented incorrectly; expected 6 spaces, found 4
359 | ERROR | Line indented incorrectly; expected 6 spaces, found 4
360 | ERROR | break statement indented incorrectly; expected 6 spaces, found 4
399 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
402 | ERROR | else must start on a new line
406 | ERROR | Line indented incorrectly; expected 4 spaces, found 6
--------------------------------------------------------------------------------

Regards
Alok

This sounds like a feature that should live in the existing uc_correios_quotes module. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the uc_correios_quotes issue queue to discuss what you need. You should also get in contact with the maintainer(s) to determine what is needed that this works for you.

If that fails for whatever reason please get back to us and set this back to "needs review".

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)