JW Player captions [#1664178]

Description

JW Player Captions adds captions support into the JW Player drupal module, using the official JW Player captions plugin.
It uses the JW Player drupal module plugin API.

This plugin can be enabled and configured in the JW player preset configuration.

This version supports :
- one or several subtitle files (SRT or XML).
- labels definition in case of several subtitle files are specified
- captions styling using color, font-family, font-size, font-style, font-weight, textDecoration attributes.

How does it work ?
For every JW Player preset, you can activate JW Player captions plugin. Then, you have to select a field for subtitle files (which can be a 'file' field or a 'link' field). You can also select a field for labels (which can be a 'file' field, a 'text' field or a 'taxonomy term' field). If you select a 'file' field, the filename without extension is used as label.

There is only a D7 version.

Ideas of improvement :
- support JW player captions plugin in the same server than the website (that means, host the captions.js/captions.swf on the server). An option should allow to select if we want to use the "local" version or the version hosted on longtail video website.
- use farbtastic color picker to select font color

git repository : git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/remy40/1652814.git jw_player_captions
sandbox page : http://drupal.org/sandbox/remy40/1652814

Comments

Comment #1

ti2m commented 28 June 2012 at 12:58

Hello and Welcome,

thanks for the module. There are some issues:

Add a link to your sandbox page and correct the Git link:
git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/remy40/1652814.git jw_player_captions

Remove the LICENSE.TXT, it will be added automatically.

Automatic review of the master branch:
PAReview shows errors: http://ventral.org/pareview/httpgitdrupalorgsandboxremy401652814git

Please check Drupal coding standards. You can use the online version of PAReview to check your project.

Please take care of these issues while waiting for a manual review.

By briefly looking at your code, I'm not sure you fullfill requirement 2.3 of the project application checklist. You have more then 120 lines of codes, but only 4 function, two of them with less then 3 lines of code. Just be aware that you might run into problems here.