Download & Extend
Metatag » Issues

Add support for Twitter's new "cards" metatags

Posted by DamienMcKenna on June 28, 2012 at 2:39pm
Project:Metatag
Version:7.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Nodewords-Metatag feature parity

Issue Summary

Twitter added a new set of meta tags called "cards".

Related issue for Nodewords: #1664324: Add support for Twitter's new "cards" metatags

Login or register to post comments

Comments

#1

Posted by nico059 on August 21, 2012 at 12:31pm

I just realease a sandbox project here: http://drupal.org/sandbox/nico059/1741784
I name it metatag_twittercard (could be changed if needed).
The code is inspired from the metatag_opengraph module.

Very basic for now (only support summary card type), but I will add the 2 others type asap
I'm waiting to participate to Twitter Card to test this module, so use at your own risk ;-)

Twitter Cards support the OpenGraph meta tags, so I leverage on this metatags (og:xyz..) for the description, title, image etc ... Not sure yet if this is the good strategy or if it's better to make metatag_twittercard independant (without dependency to the metatag_opengraph module)

Give me some feedback on this module and which feature you see important,

Enjoy ;-)

#2

Posted by Paisible on October 9, 2012 at 3:24pm

+1
I vote for this feature too.

#3

Posted by Tanzaho on October 10, 2012 at 5:42am

I ma also following this thread since I am really interested.

#4

Posted by Tanzaho on October 10, 2012 at 6:35am

I used it, and added the 'image' and 'description' tag. Waiting for twitter approval now.

#5

Posted by nico059 on October 29, 2012 at 1:22pm

Hi Tanzaho, thank you for your interest in this small module.

Could you please share the code you added for image and description? A patch, I could merge ?

Thx,
Nico.

#6

Posted by Tanzaho on November 2, 2012 at 2:28pm

I just sent you a mail. Check it out...

#7

Posted by ipwa on November 6, 2012 at 9:47am

I guess the next step would be for nico059 to make a patch on from Meta tags HEAD, adding his module as a sub module of Meta tags.

#8

Posted by kerasai on November 7, 2012 at 11:44pm

Patch rolled from latest 7.x-1.x.

AttachmentSizeStatusTest resultOperations
metatag-twittercard_support-1664322-8.patch4.88 KBIdlePASSED: [[SimpleTest]]: [MySQL] 11 pass(es).View details

#9

Posted by DamienMcKenna on November 8, 2012 at 1:20am
Status:active» needs work

Good work, but metatag_twittercard_metatag_config_default_alter() needs to be updated for the Twitter tags :)

#10

Posted by DamienMcKenna on November 8, 2012 at 3:12pm

And another sandobx: http://drupal.org/sandbox/miechiel/1835414

#11

Posted by miechiel on November 9, 2012 at 9:13am

I also started a sandbox project (see #10) to extend metatag with Twitter Cards metatag. Here is my work patched on nico059 sandbox.
This patch adds more twitter cards metatags and is using a proper metatag_twittercard_metatag_config_default_alter() function. I also added the dependency in the info file.

I'am also thinking in adding more functionality for "media" files such as images and audio/video. So that the "player" and "image" Twitter Card can be used.

AttachmentSizeStatusTest resultOperations
metatag_twittercard-combining_sandbox-1664322-11.patch5.34 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch metatag_twittercard-combining_sandbox-1664322-11.patch. Unable to apply patch. See the log in the details link for more information.View details

#12

Posted by idflood on November 12, 2012 at 7:11am
Status:needs work» needs review

Here is a patch from miechiel sandbox with some little fixes (3 whitepace issue and a double break at the same spot).

@DamienMcKenna: Anything else to have this committed to metatag?

AttachmentSizeStatusTest resultOperations
metatag_twittercard-1664322-12.patch5.69 KBIdlePASSED: [[SimpleTest]]: [MySQL] 11 pass(es).View details

#13

Posted by DamienMcKenna on November 13, 2012 at 2:49am

How's about this? :)

AttachmentSizeStatusTest resultOperations
metatag-n1664322-13.patch0 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 11 pass(es).View details

#14

Posted by DamienMcKenna on November 13, 2012 at 2:50am

Doh.

AttachmentSizeStatusTest resultOperations
metatag-n1664322-13.patch10.03 KBIdlePASSED: [[SimpleTest]]: [MySQL] 11 pass(es).View details

#15

Posted by alexweber on November 13, 2012 at 5:39pm

The patch in #14 works partially as the "twitter:card" metatag's options and human-readable name are switched so it outputs the administrative title instead of the actual value in the metatag. Also, the site's twitter account should have its context set to to global.

Patch attached.

AttachmentSizeStatusTest resultOperations
metatag-n1664322-15.patch521 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 11 pass(es).View details

#16

Posted by alexweber on November 13, 2012 at 5:42pm

Doh! Correct patch attached.

AttachmentSizeStatusTest resultOperations
metatag-n1664322-15.patch10.06 KBIdleFAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in sites/default/modules/metatag/metatag_twitter_cards/metatag_twitter_cards.metatag.inc.View details

#17

Posted by System Message on November 13, 2012 at 5:43pm
Status:needs review» needs work

The last submitted patch, metatag-n1664322-15.patch, failed testing.

#18

Posted by alexweber on November 13, 2012 at 6:40pm

getting my butt kicked. this one should do it.

AttachmentSizeStatusTest resultOperations
metatag-n1664322-15_0.patch10.06 KBIdlePASSED: [[SimpleTest]]: [MySQL] 11 pass(es).View details

#19

Posted by alexweber on November 13, 2012 at 6:40pm
Status:needs work» needs review

#20

Posted by DamienMcKenna on November 16, 2012 at 1:27am

I decided to add a README.txt file for the submodule.

AttachmentSizeStatusTest resultOperations
metatag-n1664322-20.patch11.52 KBIdlePASSED: [[SimpleTest]]: [MySQL] 11 pass(es).View details

#21

Posted by DamienMcKenna on November 16, 2012 at 1:34am
Status:needs review» fixed

Committed! Thanks everyone!

#22

Posted by DamienMcKenna on November 16, 2012 at 1:55am

Tag.

#23

Posted by DamienMcKenna on November 16, 2012 at 3:03pm
Status:fixed» closed (fixed)

Version 7.x-1.0-beta3 has been released and includes this work. Am closing this issue in an effort to keep the issue queue clean. Thank you all for your continued help!

#24

Posted by alexweber on November 16, 2012 at 10:06pm

Awesome :)

#25

Posted by jbrown on January 18, 2013 at 5:07am
Component:Code» Documentation
Status:closed (fixed)» active

This needs to be documented on the module front page.

#26

Posted by Dave Reid on January 22, 2013 at 5:48am
Component:Documentation» Code
Status:active» closed (fixed)

Added to homepage.

#27

Posted by jbrown on January 22, 2013 at 12:26pm

Thanks!