Hi,
I'm using the Forum and Advanced Forum module, together with a childship theme which uses Mothership as base theme. I got this notice and warning on the forum listing page:

    Notice: Undefined index: forums in mothership_preprocess_forum_list() (line 16 of /private/var/www/drupal7-test/sites/all/themes/mothership/mothership/functions/forum.php).
    Warning: Invalid argument supplied for foreach() in mothership_preprocess_forum_list() (line 16 of /private/var/www/drupal7-test/sites/all/themes/mothership/mothership/functions/forum.php).

I don't need Mothership to theme the forum pages since Advanced Forum is doing a great job with it. However it seems Mothership doesn't offer any options to disable Forums handling. The /functions/forum.php file is included invariably in Mothership's template.php file, even for sites that do not use Forum. From the point of view of efficiency as well, it would be great if the Forum include could be optional.

Thanks!

CommentFileSizeAuthor
#4 mothership-make_forum_handling_optional-1665298-4.patch1.61 KBey
#1 mothership-make_forum_optional-1665298-1-7.x-2.3.patch1.67 KBvictoriachan
#1 mothership-make_forum_optional-1665298-1-7.x-2.8.patch1.56 KBvictoriachan

Comments

victoriachan’s picture

victoriachan commented
Status: Active » Needs review
StatusFileSize
new mothership-make_forum_optional-1665298-1-7.x-2.8.patch1.56 KB
new mothership-make_forum_optional-1665298-1-7.x-2.3.patch1.67 KB

Hi,

I've created a patch to let admin turn forum theming on/off on theme settings. The new field, 'Forum theming' is added in the 'Mothership Misc Goodie Bag' section, below the custom 404 page template option.

I'm attaching patches for 7.x-2.8 (latest), and 7.x-2.3, which is the version I'm using.

Thanks,
Victoria

mraichelson’s picture

mraichelson commented

I think #1829082: Advanced forums causes error. is pretty much identical to this. (Though the patch I submitted over there took a different approach to addressing this.)

ey’s picture

ey commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

The patch does what it promises. I find it very useful, especially for the users who have advanced forum installed. Without this patch, there are many notices and warnings, since advanced forum also does a heavy preprocessing and changes some variables etc.

I, and surely many other users who use advanced forum would be very happy if this patch will be committed.

Thanks.

ey’s picture

ey commented
StatusFileSize
new mothership-make_forum_handling_optional-1665298-4.patch1.61 KB

I have re-rolled the patch to the latest version.

realityloop’s picture

realityloop commented
Status: Reviewed & tested by the community » Fixed

fixed

  • realityloop committed 724bc9d on 7.x-3.x 
    Issue #1665298 by victoriachan, pc-wurm: Added Make Forum handling...

  • realityloop committed 5f2a4b6 on 
    Issue #1665298 by victoriachan, pc-wurm: Added Make Forum handling...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.