Closed (fixed)
Project:
Drupal core
Version:
4.6.2
Component:
block.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Feb 2005 at 01:12 UTC
Updated:
18 Sep 2005 at 19:59 UTC
Jump to comment: Most recent file
Comments
Comment #1
andremolnar commentedconfirmed - block module does not validate 'title' field in the custom block form
'title' should be a required field - and/or validation function needs to be added to check that 'title' is unique as {boxes} table is set up with a title field as a unique key - or title field data type should be changed in {boxes} table
See lines 322 to 347 in block.module
andre (just trying to better flag bug reports)
Comment #2
Chris Johnson commentedI propose that we remove the unique key from the title column of the boxes tables, so that block boxes could have duplicate titles.
I also propose we modify the calls to form_textfield() in block_box_form() to make the desciption ('info') field be required, and the database will retain its constraint of forcing it to be unique. We should leave the title field as optional, and thus it could be blank, as is now, and because of the removal of the unnecessary unique constraint above, one could actually have multiple, untitled block boxes.
The case of duplicate description ('info') fields should be coded for in the block_box_save() routine to catch the SQL error of duplicate keys.
Comment #3
moshe weitzman commentedComment #4
ñull commentedIn 4.6 this is still an issue. Could something be done about it? Although this is not critical nor urgent, it IS irritating that not more then one untitled blocks are allowed, restricting user freedom.
Comment #5
ñull commentedIn 4.5.1 I could still use a HTML comment in the title, to make it invisible and unique. This was removed this in 4.6.x. May be it would be the simplest to allow HTML in the title again, which gives the user flexibility to use graphical title headers. In fact one of my clients is using this and it would break once I upgrade to 4.6.x.
Comment #6
ñull commentedIn 4.5.1 I could still use a HTML comment in the title, to make it invisible and unique. This was removed this in 4.6.x. May be it would be the simplest to allow HTML in the title again, which gives the user flexibility to use graphical title headers. In fact one of my clients is using this and it would break once I upgrade to 4.6.x.
Apparently the following patch is doing what I want.
Comment #7
ñull commentedIn 4.5.1 I could still use a HTML comment in the title, to make it invisible and unique. This was removed this in 4.6.x. May be it would be the simplest to allow HTML in the title again, which gives the user flexibility to use graphical title headers. In fact one of my clients is using this and it would break once I upgrade to 4.6.x.
Apparently the following patch for 4.6.2 is doing what I want.
Comment #8
tostinni commentedThis bug has been corrected in CVS version, you're encouraged to roll to the new drupal release when it will be out.
Comment #9
killes@www.drop.org commentedfixed in cvs.
Comment #10
(not verified) commentedComment #11
(not verified) commentedComment #12
(not verified) commented