I'm getting a 'Deprecated function' error on a fresh install. I get this by installing core Drupal, downloading Redhen and dependencies. I've enabled the modules according to this thread - http://drupal.org/node/1666046 - via the GUI. I then login and click on CRM Dashboard. Then when I click on either Contact, Organization, or Membership, I get the following error.

Deprecated function: Call-time pass-by-reference has been deprecated in module_load_include() (line 302 of /home/quickstart/websites/redhen.dev/includes/module.inc).

Subsequent clicks on any of those 3 links results in a "No data received - Unable to load the webpage because the server sent no data. Error 324 (net::ERR_EMPTY_RESPONSE): The server closed the connection without sending any data.' in Chrome and "The connection was reset" in Firefox.

Clearing browser and Drupal cache does nothing. I've installed 3 times with the same result.

Please help! This really looks promising!

Thanks,
Mickey

CommentFileSizeAuthor
#16 redhen_pass_by_reference_notes_1666138_16.patch695 bytesmicnap
#15 redhen_pass_by_reference_notes_1666138_15.patch623 bytesmicnap
#13 Redhen-Fixed_pass_by_reference_error-1666138-13.patch584 bytesthe_g_bomb

Comments

levelos’s picture

levelos commented
Status: Active » Postponed (maintainer needs more info)

PHP version? RedHen needs 5.3 and above. I've just updated the info files with more granular dependency info.

micnap’s picture

micnap commented

Thanks for the quick response! I'm running PHP 5.3.5 on Ubuntu 11.04. I'm using the Drupal Quickstart development environment.

Thanks,
Mickey

Summitt Dweller’s picture

Summitt Dweller commented

I am running into the same error running PHP 5.3.2 on Ubuntu 10.04. Thanks for any insight you can provide.

micnap’s picture

micnap commented

Discovered that I am able to load the Contacts, Organizations, and Memberships pages if I clear cache. Although, I am still seeing the Pass-by-reference error on those 3 pages.

Mickey

levelos’s picture

levelos commented

@micnap, any chance you can provide a call stack so I know where that error is coming from? Also made a few changes if you want to try again with the dev release / git checkout.

micnap’s picture

micnap commented
Component: Current » Shared

Thanks levelos. I'm slightly confused so here is what I did.

Set up a new Drupal install. Installed the dependencies. When I went to add Redhen, the downloadable dev version still says it's from June 29. So I cloned the git repository. Cloning the master branch gave me only a README.txt file, nothing else. So I cloned the 7.1-1.x branch. I don't know if this is the correct version I should be trying or if it is still the old version. Either way, I installed Redhen and am still getting the same as in my initial post.

Here is the call stack:

Notice: Undefined index: args in /home/quickstart/websites/redhen.dev/sites/all/modules/redhen/includes/redhen.forms.inc on line 90

Call Stack:
0.0022 331848 1. {main}() /home/quickstart/websites/redhen.dev/index.php:0
0.2849 24742064 2. menu_execute_active_handler() /home/quickstart/websites/redhen.dev/index.php:21
0.2854 24763892 3. require_once('/home/quickstart/websites/redhen.dev/sites/all/modules/redhen/modules/redhen_contact/includes/redhen_contact.pages.inc') /home/quickstart/websites/redhen.dev/includes/menu.inc:514
0.2854 24764132 4. module_load_include() /home/quickstart/websites/redhen.dev/sites/all/modules/redhen/modules/redhen_contact/includes/redhen_contact.pages.inc:8
0.2857 24855784 5. backtrace_error_handler() /home/quickstart/websites/redhen.dev/sites/all/modules/devel/devel.module:0
0.2860 24870780 6. ddebug_backtrace() /home/quickstart/websites/redhen.dev/sites/all/modules/devel/devel.module:703

And now that I know how to produce a call stack in Drupal and see the Undefined index line, I went into line 90 of includes/redhen.forms.inc and changed the $form parameter to pass by value and.... no more error!

Also had to change:
line 123 of modules/redhen_relation/includes/redhen_relation.forms.inc to pass $form_state by value to get rid of a similar error when trying to add a connection.

Hope this helps. Let me know if I can give you any more info.

Thanks!
Mickey

micnap’s picture

micnap commented

Looks like I did indeed get a different version on cloning the 7.x-1.x from git.

seanberto’s picture

seanberto commented

Hi Mickey, we good to close this ticket out as "fixed"?

micnap’s picture

micnap commented

Hi,

I just downloaded the latest code (2 minutes ago) and still had to manually remove the pass-by-reference & in the lines listed in #6 to get past the errors. The one in modules/redhen_relation/includes/redhen_relation.forms.inc is now at line 151.

There were also a couple other pass-by-references that I had to change too. I'll post them here when I run into them again.

Thanks,
Mickey

micnap’s picture

micnap commented

Ok, NOW I have the latest code. From git. And I still had to remove the pass-by-references in those two spots. I'm going to attempt to update my current partially-developed site to the latest code and see if I can find the other pass-by-references I had to change.

Thanks,
Mickey

micnap’s picture

micnap commented

Here's one of the others:

Notice: Undefined index: args in /home/quickstart/websites/pacb.dev/sites/all/modules/redhen/modules/redhen_note/includes/redhen_note.forms.inc on line 37

the_g_bomb’s picture

the_g_bomb commented

I just downloaded the alpha-2 and for me the Undefined index issues have cleared up.

[edit] No they haven't

the_g_bomb’s picture

the_g_bomb commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new Redhen-Fixed_pass_by_reference_error-1666138-13.patch584 bytes

One pass-by-reference sign was missed

levelos’s picture

levelos commented
Status: Needs review » Fixed

Got it, thanks @the_g_bomb.

micnap’s picture

micnap commented
StatusFileSize
new redhen_pass_by_reference_notes_1666138_15.patch623 bytes

And another one in Notes.

micnap’s picture

micnap commented
StatusFileSize
new redhen_pass_by_reference_notes_1666138_16.patch695 bytes

Oops. And another in relation.

levelos’s picture

levelos commented

Fixed those lingering pass by reference errors, thanks gang.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 313be10 on 7.x-1.x, tests, redhen-donation by levelos: 
    Removed lingering variable by reference errors. Ref #1666138,

  • Commit 313be10 on 7.x-1.x, tests, redhen-donation, relation-roles by levelos: 
    Removed lingering variable by reference errors. Ref #1666138,