The old code didn't wrap the iCal lines with the "\r\n" as per spec.
While this works on some parsers, others break badly with this approach
including many mobile tools.

CommentFileSizeAuthor
#2 date_ical-wrap-long-lines-1666326-2.patch1.97 KBvlad.pavlovic
0001-wrap-ical-text-fields-as-per-iCal-specification.patch2.58 KBsdague

Comments

coredumperror’s picture

coredumperror commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Active » Needs work

Thank you for reporting this issue, sdague! Could you please upgrade Date iCal to the 2.x-2.x build and, if this problem persists (I'm fairly sure it does), re-roll your patch against that branch? I'd really appreciate it.

vlad.pavlovic’s picture

vlad.pavlovic commented
Status: Needs work » Needs review
StatusFileSize
new date_ical-wrap-long-lines-1666326-2.patch1.97 KB

Re-rolled the patch for dev version.

coredumperror’s picture

coredumperror commented
Status: Needs review » Fixed

Upon reviewing this patch, I discovered that a few things didn't carry over well from it's origin as a 7.x-1.x patch. For one, drupal_html_to_text() was being called twice, so I took out the call that was being done in the view plugin code.

I also added some comments relating to full iCal spec compliance. I did some research on it, and both #61830: Text fields in iCal feeds not escaped properly and #84740: Event feed doesn't work with Google Calendar nor iCal showed me that full compliance is a hard problem, and I don't have time to really get it right. And since no one's really complaining, I'm going to leave this patch in a somewhat half-assed state of compliance for the time being.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.