Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.There is a problem with the way path module uses drupal_get_form to to build the add/edit form for path aliases.
Problem 1 - right now for adding a new alias the warning is generated: missing argument 1
Problem 2 - the function now designated as the form builder is doing things like setting the page title which should never be done in a form builder - for example, I may want to use drupal_execute on this form from another page.
It looks as though the problem was caused by a somewhat blind conversion to using drupal_get_form as the page callback, which is not appropriate in this case.
Attached path fixes these issues.
| Comment | File | Size | Author |
|---|---|---|---|
| fix_path_form_1.patch | 2.27 KB | pwolanin |
Comments
Comment #1
pwolanin commentedComment #2
eaton commented"Somewhat blind conversion" is exactly what was used. Thanks for the great catch, pwolanin!
Comment #3
gábor hojtsyI was in part guilty for this particular misuse of drupal_get_form(), committing a patch which was fixing this problem by pushing it into the wrong direction, not to eliminate drupal_get_form, but to make the code comformant to it.
So fully appreciating the fix, thanks! Committed!
Comment #4
(not verified) commented