Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Small module, but over 50% savings. :-)
Comment | File | Size | Author |
---|---|---|---|
#4 | more_help_1.patch | 832 bytes | pwolanin |
#1 | help_13.patch | 8.63 KB | Crell |
help_12.patch | 8.63 KB | Crell | |
Comments
Comment #1
Crell CreditAttribution: Crell commentedKeeping up with HEAD.
Comment #2
pwolanin CreditAttribution: pwolanin commentedno! - this just broke per-page help.
Comment #3
pwolanin CreditAttribution: pwolanin commentedmore details:
in menu.inc, function menu_get_active_help() invokes
module_hook('help', 'page')
. However, function help_page() is moved to help.admin.inc so does not exist. Thus we never see the "more help" link on admin pages.So, fuction menu_get_active_help() could use some optimization anyhow, but this bug needs to be fixed.
Comment #4
pwolanin CreditAttribution: pwolanin commentedok, seems we don't really need to invoke that function - it's just a check if the help module is enabled. So, we can substitute with
module_exists()
.Comment #5
Dries CreditAttribution: Dries commentedGood catch, and nice clean-up too!
Comment #6
(not verified) CreditAttribution: commented