Small module, but over 50% savings. :-)

CommentFileSizeAuthor
#4 more_help_1.patch832 bytespwolanin
#1 help_13.patch8.63 KBCrell
help_12.patch8.63 KBCrell

Comments

Crell’s picture

Crell commented
StatusFileSize
new help_13.patch8.63 KB

Keeping up with HEAD.

pwolanin’s picture

pwolanin commented
Status: Needs review » Needs work

no! - this just broke per-page help.

pwolanin’s picture

pwolanin commented

more details:

in menu.inc, function menu_get_active_help() invokes module_hook('help', 'page'). However, function help_page() is moved to help.admin.inc so does not exist. Thus we never see the "more help" link on admin pages.

So, fuction menu_get_active_help() could use some optimization anyhow, but this bug needs to be fixed.

pwolanin’s picture

pwolanin commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new more_help_1.patch832 bytes

ok, seems we don't really need to invoke that function - it's just a check if the help module is enabled. So, we can substitute with module_exists().

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Good catch, and nice clean-up too!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)