Safakmatik

Manual review

Welcome! In general I think the module is well made, you obviously have the required knowledge of Drupal's API. However, there are still some issues that I'd like to point out:

README.txt

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

project page

Please take a moment to make your project page follow tips for a great project page.

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Major coding standards / best practice issues

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxbluesband1667478git

files[] without classes or interfaces

files[] = safakmatik.module
Those lines should be removed. It's only necessary to declare files[] if they declare a class or interface.

Please note: The Coder module currently has an unresolved flaw which will prompt you to add file declarations to your .info file even when it's not necessary to do so. Please do not try to make this warning go away by declaring files which do not contain classes or interfaces.

Sorry this comment is a mistake!

Hello there,
this is my little contribution.

Localization
I would point something about localization. For a drupal module to be useful to the community, it should be understandable. I see you are mostly using t() calls (you maybe miss something, like .module:11 and .module:18), and thats great. Maybe a little effort in the developer direction would be appreciated, is hard for someone not familiar with Turkish to follow the code flow: i would rename variables and function names in English.

Coding
You missed some coding standard, like for control structures and array indentation, and other stuff that pareview should easily point to (you can find the link in previous review).

Your info file
I think you should remove the "version" line from your .info file.

Finally, would be nice to have your project page linked at the top of this, and i would replace your git repo link with

http://drupalcode.org:sandbox/bluesband/1667478.git

so that reviewers can quickly copy/paste it for git cloning.

Keep up the good work :)

Regards

A comment from me. When checking for the value, you should place whitespaces around ==, eg. elseif ($military_type == "UD")

Closing due to lack of activity. Feel free to reopen if you are still working on this application.