Title says it all. I will post a patch tomorrow.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | jquery_form_1.patch | 891 bytes | wim leers |
| #2 | jquery_form_0.patch | 891 bytes | wim leers |
| #1 | jquery_form.patch | 1.27 KB | wim leers |
Title says it all. I will post a patch tomorrow.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | jquery_form_1.patch | 891 bytes | wim leers |
| #2 | jquery_form_0.patch | 891 bytes | wim leers |
| #1 | jquery_form.patch | 1.27 KB | wim leers |
Comments
Comment #1
wim leersPatch attached. When committing, don't forget to remove the file
js/lib/form.js.Comment #2
wim leersUpdated patch. Now it uses the jQuery Form module if it's available, otherwise it uses the included jQuery Form plugin.
This implies that if another module uses an included version of the jQuery Form plugin, things will still go bad. Unless they would also check if the Panels 2 module is present and then not add the plugin.
Comment #3
wim leersUpdated patch. Now it uses the jQuery Form module if it's available, otherwise it uses the included jQuery Form plugin.
This implies that if another module uses an included version of the jQuery Form plugin, things will still go bad. Unless they would also check if the Panels 2 module is present and then not add the plugin.
Comment #4
wim leersSince the jQuery Form module requires the jQuery Update module, Panels has to be jQuery 1.1.x compatible. It currently isn't. This simple change fixes it: http://drupal.org/node/163509.
Comment #5
wim leersNever mind, that doesn't entirely work either, from that other issue: "Note that is will NOT work however when combined with jquery_update.module, which adds various compatibility scripts and breaks the modalContent plugin."
That's bad.
Drupal 6 will ship with jQuery 1.1.x (perhaps even 1.2) by default, so this will have to be fixed anyway. I'd appreciate it if you could give that a look ;)
Comment #6
catchhmm, bump.
Comment #7
catchand no way this applies now.
Comment #8
merlinofchaos commentedI don't think this can happen under Drupal 5.
Let's revisit this for the D6 version.
Comment #9
wim leersThe Drupal 5 version of this module is no longer maintained.