Title says it all. I will post a patch tomorrow.

Comments

wim leers’s picture

Status: Postponed (maintainer needs more info) » Reviewed & tested by the community
StatusFileSize
new1.27 KB

Patch attached. When committing, don't forget to remove the file js/lib/form.js.

wim leers’s picture

StatusFileSize
new891 bytes

Updated patch. Now it uses the jQuery Form module if it's available, otherwise it uses the included jQuery Form plugin.

This implies that if another module uses an included version of the jQuery Form plugin, things will still go bad. Unless they would also check if the Panels 2 module is present and then not add the plugin.

wim leers’s picture

StatusFileSize
new891 bytes

Updated patch. Now it uses the jQuery Form module if it's available, otherwise it uses the included jQuery Form plugin.

This implies that if another module uses an included version of the jQuery Form plugin, things will still go bad. Unless they would also check if the Panels 2 module is present and then not add the plugin.

wim leers’s picture

Since the jQuery Form module requires the jQuery Update module, Panels has to be jQuery 1.1.x compatible. It currently isn't. This simple change fixes it: http://drupal.org/node/163509.

wim leers’s picture

Never mind, that doesn't entirely work either, from that other issue: "Note that is will NOT work however when combined with jquery_update.module, which adds various compatibility scripts and breaks the modalContent plugin."

That's bad.

Drupal 6 will ship with jQuery 1.1.x (perhaps even 1.2) by default, so this will have to be fixed anyway. I'd appreciate it if you could give that a look ;)

catch’s picture

hmm, bump.

catch’s picture

Status: Reviewed & tested by the community » Needs work

and no way this applies now.

merlinofchaos’s picture

Status: Needs work » Postponed

I don't think this can happen under Drupal 5.

Let's revisit this for the D6 version.

wim leers’s picture

Status: Postponed » Closed (won't fix)

The Drupal 5 version of this module is no longer maintained.