I am providing a working module that adds Pinterest support. The code attached is not a patch file. I needed Pinterest support quickly so an add-on module was the quickest step at the time; a patch can be made from these files.

I am attaching a working D7 module (files and graphics) for Pinterest Follow support. I'd like to offer it first here for contribution before spawning another sandbox. Let me know if you want to include this.

CommentFileSizeAuthor
#14 follow-added_support_for_pinterest-1667782-14.patch7.13 KBAnonymous (not verified)
#12 follow-add_pinterest_support-1667782-12.patch1.43 KBirk
#6 folow-add_pinterest_support-1667782-6.patch1.26 KBfloydm
#6 icon-pinterest.png2.29 KBfloydm
#6 icon-pinterest.png1.5 KBfloydm
follow_pinterest.zip6.33 KBChris Charlton

Comments

WeRockYourWeb.com’s picture

WeRockYourWeb.com commented

Fantastic, works perfectly. Thanks for creating this add-on Chris!

Would love to see this officially added to the module. Given the popularity of Pinterest, I think this is a must.

laughnan’s picture

laughnan
he/him/his
commented

+1 @Chris Charlton

Chris Charlton’s picture

Chris Charlton
Primary language English
Location Los Angeles
commented

Would the module maintainers like me to generate an official patch for Pinterest support? LMK

staff_whyte’s picture

staff_whyte commented

+1

sk33lz’s picture

sk33lz commented

Chris, please provide a patched version so the community can review and test it so that it may possibly be accepted into the module.

Thanks!

floydm’s picture

floydm commented
Status: Active » Needs review
StatusFileSize
new icon-pinterest.png (small)1.5 KB
new icon-pinterest.png (large)2.29 KB
new folow-add_pinterest_support-1667782-6.patch1.26 KB

A patch made against the current 7.x-1.x branch in git is attached.

The two icons also need to be dropped into the icons/large and icons/small directories.

Chris Charlton’s picture

Chris Charlton
Primary language English
Location Los Angeles
commented

@Floydm, did you generate the patch using my Pinterest ZIP file above?

@Matainers, let us know if Floydm's patch is good enough otherwise I'll generate another.

floydm’s picture

floydm commented

@Chris Charlton My patch adds Pinterest to the core follow module rather that uses an additional module but it is based on your work.

@Maintainers: if I could help roll this patch and a few others into a single patch, please let me know! I'd love to see follow get a stable 7.x-1.0 version before the time comes to start work on the 8.x version.

Candidates for a mega patch:
#1667782: Pinterest support
#1667778: Undefined index in theme_follow_links() when custom follow add-on modules disabled
#1879484: Support for instagram and pinterest
#1729028: Google+ Needs rel="publisher" in link
#1667778: Undefined index in theme_follow_links() when custom follow add-on modules disabled
#1419474: Add Views to D7 version of Follow

sk33lz’s picture

sk33lz commented
Status: Needs review » Reviewed & tested by the community

Patch works great against 7.x-1.x-dev. Thanks!

This is why the Drupal community rocks :D

q0rban’s picture

q0rban commented

Ok, we have duplicate issues here, each set to RTBC (See #1895014: Support Pinterest). Can someone review both patches please and make a call on which to use?

irk’s picture

irk commented
Status: Needs review » Reviewed & tested by the community

After reviewing both patches, I would say @Floydm's patch suits better since it adds the icons. But I'm confused why the images themselves can't be included in the patch.

EDIT: Actually the other patch is for the 2.x branch so it's not a duplicate. By what I can see, each should be applied to their respective branch.

irk’s picture

irk commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new follow-add_pinterest_support-1667782-12.patch1.43 KB

Attaching updated patch with the new image files included. The code hasn't changed other than removing added whitespaces in the module file. Good work @Floydm.

Status: Reviewed & tested by the community » Needs review

Correcting issue status, see #2125263: Issue status not taken from last comment during D7 migration.

Anonymous’s picture

Anonymous (not verified) commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Issue summary: View changes
Related issues: +#2209847: Add new icons from Paul Robert Lloyd's socialmediaicons
StatusFileSize
new follow-added_support_for_pinterest-1667782-14.patch7.13 KB

Here's a patch for the 7.x-2.x branch that adds support for Pinterest with icons. Note that it requires the patch from #2209847: Add new icons from Paul Robert Lloyd's socialmediaicons to add one of the new icons.

Once this is tested and committed it can be backported to the 7.x-1.x branch.

Anonymous’s picture

Anonymous (not verified) commented

Marked #1895014: Support Pinterest as a duplicate of this issue.

astonvictor’s picture

astonvictor commented
Status: Needs review » Closed (outdated)

I'm closing it because the issue was created a long time ago without any further steps.

if you still need it then raise a new one.
thanks