Closed (fixed)
Project:
Facet API
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
2 Jul 2012 at 16:07 UTC
Updated:
17 Jul 2012 at 20:41 UTC
Jump to comment: Most recent file
Various components should be refactored for better unit testing. Since the logic is jumbled in the __construct() method, it makes it difficult to test as there are no return values to work with. The areas that could be moved into separate methods are the following:
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | adapter-refactor-1668484-1.patch | 12.88 KB | cpliakas |
Comments
Comment #1
cpliakas commentedThe attached patch refactors the constructor and adds additional tests that can now happen because of the refactoring.
Comment #2
cpliakas commentedLight is green, trap is clean. Committed to the 7.x branches of Facet API.