Repeatable: Always.

Steps to repeat:
1. Install Drupal 8.x
2. Go to the FrontPage of your site as the admin.
3. Click in the dropdown menu of the "Powered by Drupal" block.

Expected Results:
The "Configure block" option is visible.

Actual Results:
"Configure block" font is white, making the option not visible.

Notes:
The text is visible when highlighted.
"Configure block" is visible in the other blocks.

OS: Windows 7 Professional, SP1
Database: MySQL 5.5.24
Web Server: Apache 2.2.22
PHP 5.3.13
Drupal 8.x

CommentFileSizeAuthor
#9 drupal-clean_bartik_footer_css-1668808-9.patch1.66 KBmbrett5062
#4 1668808-configure_block.patch1.27 KBchintan.vyas
#1 block-1668808-0.patch1.27 KBchintan.vyas
configure block not visible VS visible.png48.07 KBLautaroM

Comments

chintan.vyas’s picture

chintan.vyas commented
StatusFileSize
new block-1668808-0.patch1.27 KB

Hello,

I think its not a block specific problem. Its the Footer region which is creating problem. If you add any block in footer you will get same proble. I have made patch for that, please review it.

Regards,
Chintan Vyas.

chintan.vyas’s picture

chintan.vyas commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, block-1668808-0.patch, failed testing.

chintan.vyas’s picture

chintan.vyas commented
Status: Needs work » Needs review
StatusFileSize
new 1668808-configure_block.patch1.27 KB

This patch resolves the issue of footer block configure.

Status: Needs review » Needs work

The last submitted patch, 1668808-configure_block.patch, failed testing.

chintan.vyas’s picture

chintan.vyas commented

Can anyone please explain why my patch #4 is getting failed in automated testing? In test details it says Drupal\search\Tests\SearchCommentTest - Non pass. cant figure out the problem.

tom verhaeghe’s picture

tom verhaeghe commented
Status: Needs work » Needs review

#4: 1668808-configure_block.patch queued for re-testing.

mbrett5062’s picture

mbrett5062 commented

I actually think the problem should be addressed in a different way. The issue stems from the less specific and somewhat contradictory styling of the 'footer/footer-wrapper' in the Bartik theme.

The following should not be done IMHO.

#footer-wrapper a {
  color: #fcfcfc;
  color: rgba(255, 255, 255, 0.8);
}

This creates all sorts of problems. There is also a lot of margin and padding styling done to early, it should be more specific.
If we can we should avoid the need to use !important just to override incorrect styling on wrappers.

The '#footer-wrapper a' styling should be moved into '#footer .block .content a'

I am working on a patch now that will resolve the issue without the addition on !important at all, and retain the styling of the blocks in the footer as is.

mbrett5062’s picture

mbrett5062 commented
StatusFileSize
new drupal-clean_bartik_footer_css-1668808-9.patch1.66 KB

OK here is a patch that cleans up the CSS in Bartik theme only in the Footer. No need for !important, still leaving styling of block content as is.

benjy’s picture

benjy commented
Status: Needs review » Closed (cannot reproduce)

This seems to be fixed in HEAD