I added stumbleupon to the service links and I'm trying to get registered as an allowable contributor to upload my addition to the source. Of course, if someone else wants to add it into the source and save me the trouble...

Also, I noticed that the service link can (line) break between a service image and it's text description, which is -IMHO- a flaw. (see attached screenshot) adding an " " doesn't seem to solve this problem, so I was wondering if anyone else had any ideas or wanted a crack at it.

CommentFileSizeAuthor
#7 StumbleUpon.02.patch3.59 KBNaX
#5 StumbleUpon.patch2.96 KBNaX
screenie[9].Png6.61 KBjakemonO

Comments

jakemonO’s picture

jakemonO commented

the " " in the previous message should read " "

apsivam’s picture

apsivam commented

can you provide a patch

costik’s picture

costik commented

I'd love to have this added, too.

costik’s picture

costik commented

Open service_links.module, and scroll down to where it says:

  // Add your own link by modifing the link below and uncomment it.
  //$links['service_links_delicious'] = theme('service_links_build_link', t('Delicious'), "http://del.icio.us/post?url=$url&title=$title", t('Bookmark this post on del.icio.us.'), 'delicious.png', $nodelink);

Paste in:

  $links['service_links_stumbleupon'] = theme('service_links_build_link', t('StumbleUpon'), "http://www.stumbleupon.com/submit?url=$url&title=$title", t('Thumb this up at StumbleUpon'), 'stumble1.gif', $nodelink);

Save the file. If you want the stumble1.gif file because you're displaying images with your service links, you can get it here:

http://www.stumbleupon.com/integrate.php

Save to the same directory as service_links.module.

Note: This isn't a "patch" because some magic has to happen in the service_links_admin_settings function to allow administrators to turn display of this on or off, but I'm not enough of a Drupal guru to figure this out, at least at this hour.

NaX’s picture

NaX commented
Status: Active » Needs review
StatusFileSize
new StumbleUpon.patch2.96 KB

This patch adds support for stumbleupon and adds support for $service_links var in page.tpl.php.

starkos’s picture

starkos commented

Tried the patch here, works as advertised. You can see it at http://industriousone.com/

NaX’s picture

NaX commented
StatusFileSize
new StumbleUpon.02.patch3.59 KB

Here is an update to the last patch. It just fixes the title that is passed into the links for when the links are used on pages that are not nodes. It also appends the site name to the title if it is enabled in the current theme.

owen barton’s picture

owen barton commented
Status: Needs review » Fixed

This appears to be committed in the latest DRUPAL-5 branch

apsivam’s picture

apsivam commented
Status: Fixed » Closed (fixed)