User name instead of user ID in Contacts list

Forgot one thing: I would also like the Contacts list to only show users from my buddylist who have enabled private messages in their profile.

So another update: I see now that on the list of contacts I get a correct username when I've sent a PM to another user outside of my buddylist. The ones from my buddylist only get uid (numerical) names in the list of contacts, even the one I've sent PM to.

Update on the first issue (uid instead of name for the users from my buddylist): I think this is a bug.

Line 1646 in privatemsg.module (the version as of August 17) has

$contacts[check_plain($buddy->uid)] = $buddy->uid;

but I think it should be

$contacts[check_plain($buddy->name)] = $buddy->uid;

At least it seems to work fine. :)

An to the second issue: I think this can be solved by changing in function privatemsg_contacts_form() from:

while ($buddy = db_fetch_object($result)) {
$contacts[check_plain($buddy->uid)] = $buddy->uid;
}

to

while ($buddy = db_fetch_object($result)) {
if (privatemsg_message_allowed($user->uid)) {
$contacts[check_plain($buddy->name)] = $buddy->uid;
}
}

Seems to work for me.

Uhm... Think it should be

privatemsg_message_allowed($user->uid, $buddy->uid)

insted of

privatemsg_message_allowed($user->uid)