Adjust system.performance configuration for new guidelines

hmm, not sure about the naming

cache: '0'
page:
    cache_maximum_age: '0'
    compression: '0'
preprocess:
    css: '0'
    js: '0'

or

cache:
    enabled: '0'
    maximum_age: '0'
compression: '0'
preprocess:
    css: '0'
    js: '0'

or ???

I wonder if the compression variable should reflect the fact the we can respond to more than just HTTP and in order for compression to work the request header HTTP_ACCEPT_ENCODING must be set and contain the value gzip. So maybe something like:

cache:
    page:
        enabled: '0'
        max_age: '0'
bandwidth_optimization:
    http_response_gzip: '0'
preprocess:
    css: '0'
    js: '0'

Or maybe http_encode_gzip instead of http_response_gzip?

Done (hopefully)

#8: drupal8.config-system-performance.8.patch queued for re-testing.

This is fun...

      $parts = explode('.', $key);
      if (count($parts) == 1) {
        return isset($merged_data[$key]) ? $merged_data[$key] : NULL;
      }
      else {
        $key_exists = NULL;
        $value = drupal_array_get_nested_value($merged_data, $parts, $key_exists);
        return $key_exists ? $value : NULL;
      }

When there are multiple parts, drupal_array_get_nested_value gets called. But in early bootstrap common.inc isn't loaded yet.
So we should copy the functionality or move the function to bootstrap.inc. (or any other file that get bootstrapped soon)

Anyone has another idea?

And isn't there an update function somewhere for system performance settings? o_O

#8: drupal8.config-system-performance.8.patch queued for re-testing.

Should pass now..

#17: drupal8.config-system-performance.17.patch queued for re-testing.

We're missing an upgrade path from variables to config... and what about existing drupal 8 install?

The patch attached adds the missing upgrade from variables. Not sure how to deal with existing drupal 8 sites...

 /**
+ * Moves system performance settings from variable to config.
+ *
+ * @ingroup config_upgrade
+ */
+function system_update_8015() {
+  update_variables_to_config('system.site', array(
+    'cache' => 'cache.page.enabled',
+    'page_cache_maximum_age' => 'cache.page.max_age',
+    'page_compression' => 'response.gzip',
+    'preprocess_css' => 'preprocess.css',
+    'preprocess_js' => 'preprocess.js',
+  ));
+}

The patch also changes the key order in the YAML file to be alphabetical.

-cache: '0'
-page_cache_maximum_age: '0'
-page_compression: '0'
-preprocess_css: '0'
-preprocess_js: '0'
+cache:
+    page:
+        enabled: '0'
+        max_age: '0'
+preprocess:
+    css: '0'
+    js: '0'
+response:
+    gzip: '0'
+

For some reason the inderdiff was weird...

Rerolled patch to apply to latest 8.x

Also marking this as critical as we've broken the upgrade path as there currently is no migration of these settings for 7.x -> 8.x

fwiw the naming here looks fine to me, and I agree with renaming maximum_age to max_age since it's actually setting that in the cache-control header.

Some of new code was doing $config->get('cache')

#23: 1669902.drupal8.config-system-performance.23.patch queued for re-testing.

Looks great!

Committed and pushed to 8.x. Thanks! :D