The function node_revisions() has redundant code (it rechecks for access that was already checked by function _node_revision_access()) and also looks at arg(1), arg(3), etc. instead of using params passed into the function from the menu system.

Attached patch corrects the worst of these deficiencies.

CommentFileSizeAuthor
#2 revargcleanup.patch3.28 KBbdragon
func_node_revisions_clean_1.patch2.96 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Needs review » Needs work

needs re-roll for node module split

bdragon’s picture

bdragon commented
Status: Needs work » Needs review
StatusFileSize
new revargcleanup.patch3.28 KB

Free reroll courtesy patch bingo.

bdragon’s picture

bdragon commented
Status: Needs review » Closed (fixed)

Closing -- ended up getting fixed in #201536: Document menu_get_object().
http://drupal.org/node/201536#comment-665103