Hi,

I'm trying to write tests for the entity translation module, in particular a patch which integrates ER with the i18n_menu module. See #1444866: UI for translation of menu items for entity-translated nodes.

The i18n module is a dependency for the integration patch and respective tests; however, it's optional for the main module and therefore not listed as a dependency in the main .info file.

The problem is that the testbot does not download the i18n module.

According to #698932-39: "test_dependencies" for dependencies / integration tests, this can be solved by moving things to a submodule which does specify the dependency. So I tried that: I moved the patch contents to a submodule entity_translation_i18nmenu, and added i18n as a dependency in the respective .info file. Unfortunately the test-bot still does not download i18n...

What am I doing wrong? Any ideas?

Comments

bforchhammer’s picture

bforchhammer commented

For reference, here's the failing test: http://qa.drupal.org/pifr/test/295113

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Note that the testbot only sees/re-calculates dependencies in named releases. Both of your own project and dependencies (it will always depend on the latest named release, not the -dev snapshot).

So, make sure that the test class has a dependencies => array('i18n_menu') in the getInfo() array then the testbot should ignore the tests for the moment and after commiting and releasing a new version, it should get picked up and he should start running those tests.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Project Dependency *prefers* the recommended release, which will not be the dev. But it uses the dev if there's no recommended.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Project: Project Dependency » Drupal.org Testbots
Version: 6.x-1.x-dev »

Moving this to testbot queue for triage; it's usually a support issue.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Fixed

@bforchhammer, are you trying to *add* dependencies in this patch? I don't think that can ever work. Dependencies are generated from releases. @Berdir had it right in #2 . I didn't read his 2nd paragraph carefully enough.

Marking fixed, but feel free to reopen.

bforchhammer’s picture

bforchhammer commented

@Berdir: adding the 'dependencies' key to getInfo() worked in terms of getting the testbot to ignore them, thanks!

@rfay: Yes, exactly. I am adding new dependencies with the patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.