Recent php versions (5.4.4 here) enable more strict checks, I am getting:

Strict warning: Only variables should be passed by reference in media_colorbox_callback() (line 14 of /home/ao2/public_html/test/sites/all/modules/contrib/media_colorbox/media_colorbox.pages.inc).

A patch is on its way to fix that.

Ciao,
Antonio

P.S. Thanks fot the great module.

CommentFileSizeAuthor
#3 0001-Issue-1672230-by-ao2-Fix-a-Only-variables-should-be-v2.patch1.3 KBao2
#1 0001-Issue-1672230-by-ao2-Fix-a-Only-variables-should-be-.patch1.3 KBao2

Comments

ao2’s picture

ao2 commented
Status: Active » Needs review
StatusFileSize
new 0001-Issue-1672230-by-ao2-Fix-a-Only-variables-should-be-.patch1.3 KB

Patch attached, it was made with git format-patch please apply it with git am so I show up as the author in the project history.

Thanks,
Antonio

RandalK’s picture

RandalK commented
Status: Needs review » Needs work

Error upon patching:
Parse error: syntax error, unexpected T_PRINT in /sites/all/modules/media_colorbox/media_colorbox.pages.inc on line 15

Inspecting the file shows there's a missing comma on line 14.

Looks good besides that.

ao2’s picture

ao2 commented
Status: Needs work » Needs review
StatusFileSize
new 0001-Issue-1672230-by-ao2-Fix-a-Only-variables-should-be-v2.patch1.3 KB

Thanks @RandalK, sorry for the hiccup.

Fixed patch attached (ready for git am, I keep mentioning that because some Drupal maintainers don't know about it...).

RandalK’s picture

RandalK commented
Status: Needs review » Reviewed & tested by the community

Pretty simple fix, looks good to me.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Reviewed & tested by the community » Closed (fixed)

Seems to already be in the latest dev branch.