Closed (fixed)
Project:
External Links
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
5 Jul 2012 at 15:20 UTC
Updated:
8 May 2018 at 00:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
lahode commentedJust change in extlink.js $(this).after by $(this).before everywhere
Something nicer would be to include the option in extlink_admin_settings, like:
Then add line 24 after drupal_add_js(array('extlink' => array( :
And in your extlink.js file, change the line:
by:
Cheers
Comment #2
elachlan commentedCould be a possible inclusion. Submit a patch and we will see about including it.
Comment #3
drcolossos commentedSince we needed this functionallity, I created a patch from the above. I slightly changed some of the wordings and changed the way the JavaScript is handled. Created against the latest dev
Comment #4
drcolossos commentedThis patch has been around for quite some time, also with the refactored Javascript. We would love to have this feature available without patching the module. Please check the patch and let me know if anything needs changing.
Comment #5
elachlan commentedCould you re-roll it to the latest version?
Also I may need to get the OK from quicksketch before a release, but we should be able to include it in dev for now.
Comment #6
drcolossos commentedSo, i finally managed to update the little patch. It's against the latest 7.x-1.x branch. I also rephrased some of the old wordings from my last patch.
Comment #8
elachlan commentedI have pushed the change through.
Thanks you!
Comment #9
damienmckennaNeeds an update to hook_uninstall() to remove the new variable.
Comment #10
osopolarThis works for me. As this was already fixed in the dev version I created a new issue for #9: #2508509: Delete only variables set by extlink on uninstall.
Comment #12
elachlan commentedComment #13
elachlan commentedComment #15
elachlan commentedComment #17
elachlan commentedComment #19
elachlan commented