When viewing a webform submission, the breadcrumb path links to node/%webform_menu/submissions
That page only shows the submissions for the current user, and will display a confusing "There are no submissions for this form." in many cases, even if there's +100 submissions by other users already.

Suggestion: change the breadcrumb based on the users permission.

Patch will follow.

CommentFileSizeAuthor
#1 confusing_breadcrumb_on_submissions-1673422-1.patch849 bytesrv0

Comments

rv0’s picture

rv0 commented
Status: Active » Needs review
StatusFileSize
new confusing_breadcrumb_on_submissions-1673422-1.patch849 bytes

Patch kindly provided by Coworks Drupal Team

quicksketch’s picture

quicksketch
he/him
commented

Makes sense to me; I thought we were already doing something similar but I guess not. I'll review/commit this when I get a chance.

quicksketch’s picture

quicksketch
he/him
commented
Priority: Normal » Minor

Committed to 7.x-3.x and 7.x-4.x. We can reroll if desired for D6, but this is so minor I don't think it's a big deal.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Robin Millette’s picture

Robin Millette commented
Status: Closed (fixed) » Needs work

There is no $account variable in that function.

      elseif (user_access('access own webform results', $account)) {

should be

      elseif (user_access('access own webform results')) {
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue summary: View changes
Status: Needs work » Closed (fixed)

Check the documentation:
https://api.drupal.org/api/drupal/modules!user!user.module/function/user...

Function signature:
user_access($string, $account = NULL)

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

If you are referring to the issue raised in #1763664: Error on each form submission - breadcrumb, that has been fixed.