Closed (fixed)
Project:
Nice messages
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Reporter:
Created:
6 Jul 2012 at 12:19 UTC
Updated:
28 May 2014 at 01:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
kaldimar commentedSubscribing, I'd like to have this module available in the public area for form submission feedback and so.
Comment #2
SweetTomato commentedThis seems to be implemented (Set default global settings to show messages the "nice" way). But I dont' see results on my site. Is there possibly an issue with this function that checks if nice messages are enabled?
I'd like to work through it as well, so if anyone knows what
user_access('toggle nicemessages')does, I would appreciate your knowledge. (I think the user_access function checks if a user has a setting enabled, and not adding the user ie user_access(permission) instead of user_access(permission, user) just checks if that permission exists?As a user, you can set "use nice messages" to None, Yes, or No. Where is this code responding to that permission being none?
Comment #3
dqdSweetTomato: Thanks for bringing some light into it. Which version of nice messages do you use? rc1 or dev?
I would love to move it to dev, since it seems to be an unfinished feature in the code.
Comment #4
dqdComment #5
dqdOk, I am already working on it. And it seems to work how I changed the forms now. There was also a typo in an older patch of somewhen. ALl together I think I've created a better option logic now, since user based on/off only makes sense for logged in users, and a global ON should take effect for all users, also anonymous. I will commit to HEAD of 2.x dev next hours, since I made some other small changes and it makes no sense to create a patch for this here. I will rather create a new release (2.x) to inform users to make an update to have this feature finally implemented. All other settings will not be affected.
Comment #6
dqdComment #7
dqdI also have added some style features (f.e. facebook style) and optimized the options for shadows with no extra comment or issue here. So this patch is a collection of changes including this feature request but for release history only and will be committed to new dev release. To use the options from this fixed issue here, please just simply update Nicemessage module to the latest dev or release version 2.x.
Comment #9
dqdComment #10
dqd