Back port of quickbar_extras and add a logout link

Hi,

I did the backport patch and updated the module folder. Ran update.php. Quickbar_Extras appears in the modules. I enabled it. However, it does not appear anywhere -- in Site configuration as separate module, or under Quicbar configuration (which appears no different than before patch.)

Did I miss a step? Or is there an issue that the patch does not include reference to extras in the original quickbar.module ??

FYI, here is record of what happened on terminal when I patched the module:
$ patch < back_port_quickbar_extras-1673742-1.patch
patching file quickbar_extras.css
patching file quickbar_extras.admin.js
patching file quickbar_extras.info
patching file quickbar_extras.install
patching file quickbar_extras.module

thanks much

Hi Guy,

Thanks so much for the quick response. I'm trying this out on a dev site online. I ran the update.php script even though I suspected it wasn't needed. I also cleared cache even though it was disabled. I've attached the .png shot of my screen when I went to admin/settings/quickbar, but I don't see any link for configure beside any of the role assigned menus, nor do I see anywhere how to access new options.

Thanks for your patience on this.

geoff

Thanks, Guy.

And I appreciate your response and courtesy. Sorry it's not working for me. I had already assigned a menu to the administrator role. I assigned another menu to another role. But I still am not seeing any links for configure.

thanks,
geoff

The attached patch only applies to the development version, 6.x-1.x-dev. So that's why the configure link isn't available. But after enabling quickbar extras module, the configure link results in a WSOD.

I just tested the patch in #10 on a clean install of D6 and Quickbar 6.x-1.x-dev. After patching the configure link works and the extra settings appear.

The positioning of menu links under "Organize Menu Links" seems to work fine on the left or right, but I'm getting some errors with the User Settings.

Showing the username in the toolbar works fine but when enabling the "Username links to user profile page" results in the following error:

warning: htmlspecialchars() expects parameter 1 to be string, array given in /path/to/drupal/includes/bootstrap.inc on line 860.

The same error message also shows up when enabling the "Include a Log out link" option.

I've tracked down the errors to lines 228 and 240 of the quickbar extras module which is creating the links. In a nutshell the class attribute didn't need to be an array. In fact, the class wasn't being added because of this.

I've attached a patch that fixes this. I've also rewritten how those links are being added which looks more consistent with the rest of the links in the menu. It applied cleanly to 6.x-1.x-dev.

I'll need someone who is willing to maintain the d6 version of quickbar. Then this patch can go in.

I'd be up for maintaining the D6 version after the patch goes in since I've still got a few D6 sites around that are using quickbar. But only for bug fixes since D6 doesn't have much of a lifespan left.

@jeni_dc Thanks you've been added as a maintainer. Feel free to commit any patches needed for d6.

Thanks redndahead!

This has been committed to dev.

http://drupalcode.org/project/quickbar.git/commit/c525025