SQL warnings when user has manipulate queue permission

Posted by mlncn on August 15, 2007 at 4:01am

5 followers

Issue Summary

Line 444 I think is commented out, and results in warnings like the following:

* warning: array_fill() [function.array-fill]: Number of elements must be positive in /home/example/public_html/auction2007/modules/contributed/nodequeue-4.7.x-1.2/nodequeue/nodequeue.module on line 445.
* warning: implode() [function.implode]: Bad arguments. in /home/example/public_html/auction2007/modules/contributed/nodequeue-4.7.x-1.2/nodequeue/nodequeue.module on line 447.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT nq.qid FROM dru_nodequeue_queue nq INNER JOIN dru_nodequeue_types nt ON nt.qid = nq.qid INNER JOIN dru_nodequeue_roles nr ON nr.qid = nq.qid WHERE nt.type = 'product' AND nr.rid IN () in /home/example/public_html/auction2007/includes/database.mysql.inc on line 121.

Uncommenting out the line removes the error, though I never noticed the functionality change.

benjamin, Agaric Design Collective

Comments

#1

Posted by merlinofchaos on May 28, 2008 at 5:53pm

Status:

active

» closed (won't fix)

The nodequeue 1.x line is no longer available.

#2

Posted by nbz on July 27, 2008 at 2:37am

Version:	4.7.x-1.2	» 6.x-2.0-rc1
Priority:	minor	» critical

I am getting very similar errors with nodequeue 2.0-rc1:

    * warning: array_fill() [function.array-fill]: Number of elements must be positive in /var/www/vhosts/therevival.co.uk/httpdocs/includes/database.inc on line 240.
    * warning: implode() [function.implode]: Bad arguments. in /var/www/vhosts/therevival.co.uk/httpdocs/includes/database.inc on line 240.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT nq.qid, nq.show_in_tab, nq.show_in_links, show_in_ui FROM nodequeue_queue nq INNER JOIN nodequeue_types nt ON nt.qid = nq.qid INNER JOIN nodequeue_roles nr ON nr.qid = nq.qid WHERE nt.type = 'page' AND nr.rid IN () in /var/www/vhosts/therevival.co.uk/httpdocs/sites/all/modules/nodequeue/nodequeue.module on line 1561.

This is from the node/%/nodequeue page - the nodequeue options do not show. Also, adding text to the add to nodequeue/remove from nodequeue options also gives similar errors on other pages(such as the homepage.)

#3

Posted by nbz on July 27, 2008 at 9:53pm

Status:

closed (won't fix)

» active

#4

Posted by nbz on August 9, 2008 at 9:40pm

Moer info - this only happens if a user has permission to manipulate queues. The the user also has permission to manipulate all queues, the error messages go away.

(I am sorry for jumping in this issue - I think it may be different from the original wontfix issue, but I have already posted in this issue for this bug...)

#5

Posted by nbz on August 9, 2008 at 9:42pm

Title:

SQL warnings due to commented-out line

» SQL warnings when user has manipulaet queue permission

#6

Posted by ezra-g on August 10, 2008 at 9:54pm

Title:	SQL warnings when user has manipulaet queue permission	» SQL warnings when user has manipulate queue permission
Status:	active	» postponed (maintainer needs more info)

This certainly is a critical issue.

In my testing, the patch at #275236: Manipulate all queues permission doesn't work also resolves this issue. Can you please confirm?