Download & Extend
SoundCloud Tools » Issues

Syntax Error on Install

Posted by fadgadget on July 7, 2012 at 7:08pm
Project:SoundCloud Tools
Version:6.x-1.0-beta1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

Hello i get this error when i try to enable this module.

Parse error: syntax error, unexpected ';', expecting ')' in /home/xxxxx/public_html/sites/all/modules/soundcloud_tools/soundcloud_api.module on line 96

I deleted the module. Love to use it.

thanks

Login or register to post comments

Comments

#1

Posted by WhereverPanda on July 9, 2012 at 10:48am

I'm getting this error as well. This module would be a LIFE SAVER if it worked...

#2

Posted by mjonesdinero on July 10, 2012 at 5:15am

Hi every one did you upload the soundcloud in https://github.com/mptre/php-soundcloud/downloads and put it on /sites/all/modules/soundcloud_tools folder?

#3

Posted by mjonesdinero on July 11, 2012 at 2:26am
Status:active» needs review

also please reply to me if you are still getting error when you have already put the Services folder..
attach
patch apply to git off of the error

#4

Posted by mjonesdinero on July 11, 2012 at 2:33am

sorry here is the patch

AttachmentSize
syntax-error-on-install-1674930-4.patch 628 bytes

#5

Posted by WhereverPanda on July 11, 2012 at 6:56am

Thank you so much for the patch, it seems to do something, although now there is a new error which breaks the whole site:

Parse error: syntax error, unexpected T_FUNCTION, expecting ')' in ........./soundcloud_tools/Services/Soundcloud.php on line 685

#6

Posted by mjonesdinero on July 11, 2012 at 8:26am

hi are you testing this in your localhost or in a live site? because in my localhost i have no error on this..
and it is running smoothly

#7

Posted by WhereverPanda on July 11, 2012 at 1:35pm

I am building online, so that might be where the issue is.

#8

Posted by mjonesdinero on July 12, 2012 at 12:40am

HI please update the file

/soundcloud_tools/Services/Soundcloud.php line 685

current code
$postData = array_map(function ($track) {

please change to
$postData = array_map(function ($track)) {

#9

Posted by WhereverPanda on July 13, 2012 at 11:44am

Damn, no sorry, man. It still doesn't seem to help the problem. :/

#10

Posted by mjonesdinero on July 16, 2012 at 12:28am

is the problem still exists? hmff.. is the problem the same from what you have stated in #5?

#11

Posted by mjonesdinero on July 17, 2012 at 2:39am

line 682-701.. please change the current function with this one...

public function updatePlaylist($playlistId, $trackIds, $optionalPostData = null)
    {
        $url = $this->_buildUrl('playlists/' . $playlistId);
        $postData = array_map(function($track){ return 'playlist[tracks][][id]=' . $track;} , $trackIds);

        if (is_array($optionalPostData)) {
            foreach ($optionalPostData as $key => $val) {
                array_push($postData, 'playlist[' . $key . ']=' . $val);
            }
        }

        $postData = implode('&', $postData);
        $curlOptions = array(
            CURLOPT_CUSTOMREQUEST => 'PUT',
            CURLOPT_HTTPHEADER => array('Content-Length' => strlen($postData)),
            CURLOPT_POSTFIELDS => $postData
        );

        return $this->_request($url, $curlOptions);
    }

#12

Posted by mjonesdinero on July 17, 2012 at 2:40am

also what php version are you using?

because if it is 5.2 it will make an error.. you must update the version to 5.3

#13

Posted by nepasisiht on July 18, 2012 at 2:46pm

Just chipping in to say that comment #4's patch fixed a white screen issue on a PHP 5.3 server, so thank you.

#14

Posted by WhereverPanda on July 19, 2012 at 9:40am

At least I know there is hope. On my test domain I have PHP Version 5.2.17, but I know most have 5.3.
I'll have to set up on a new server and check again to see if I can get it working!!

#15

Posted by mjonesdinero on July 20, 2012 at 12:48am

@WhereverPanda
just post a feedback here if there are some issue

#16

Posted by WhereverPanda on February 19, 2013 at 1:55pm

It's been a long time, but I have finally started playing with this module again, and it works BEAUTIFULLY now. Seriously, awesome module - and it works flawlessly.
The only thing I am personally missing is an option to use an HTML5 player instead of flash. Will you by any chance be looking into this in the future?