Hi!

I have used this module with 4.6 and have modded it somewhat to meet out company's needs. I am really glad that development has started again and I decided to upgrade our intranet to 5.2. I downloaded the latest development snapshot (attached) and integrated it with the site I have also ported my mods to it (attached). The following features have been added:
1. Works with Drupal 5.2
2. Alternative compact list view (hardcoded)
3. Printer friendly page (of compact list view)
4. Download VCards
5. Added callto: links (requires one line update to filter module to support "callto:" protocol)
6. Added moderator function for updates.
7. Support for custom fields using mozillaOrgPerson: Skype and Privat mobile (hardcoded)

The features are specifically adapted to our company's needs but my hope is that they are still generic enough for most people's uses. The code may not be the prettiest or follow Drupal best-practice, but unfortunately I do not have more time to polish my changes.

1. Uploading pictures does not work, although I have not tested that so much since we have been using phpLDAPAdmin.
2. I have added a "$user->uid" check that need to be verified.
3. The "Search Address Book" link points only to the root page (see screenshot). I don't know how to fix that.
4. There are some hardcoded paths to the images, i.e. "modules/". However, the modules can be placed in a subdirectory, e.g. modules/contrib, which breaks the images paths.
5. There are some bug fixes made, which you can see from a diff of the attached files.

Some feedback:

1. It would be better to have a textarea for the "Fields of interest" and "Fields for summaries" since these lists can be very long.
2. In the "todos", the LDIF import/export todo is probably not interesting for end-users. VCard support is more useful since it is recognised by most clients.
3. I am not sure, but can images be included in VCards?

Just let me know if you need more info.
/Kevin

Comments

kevin.mcnamee@mailbox.org’s picture

Title: Feature requests (Working example for 5.2 attached) » Screenshot
StatusFileSize
new51.05 KB

Here is the screenshot.

kevin.mcnamee@mailbox.org’s picture

Title: Screenshot » Original code
StatusFileSize
new34.43 KB

Here is the original code which can be used for diffs.

kevin.mcnamee@mailbox.org’s picture

Title: Original code » New features and feedback (Working example attached for 5.2)

Changed title

kevin.mcnamee@mailbox.org’s picture

Version: 4.7.x-1.x-dev » master
ashenoy’s picture

Hi,

Just tried using the modded ldap_addressbook on Drupal 5.1. It installs and configures up just fine...however, I do not find anything at http://URL/ldap_addressbook.

http://URL/ldap_addressbook/search allows me access to a "New Contact" form. No access to the "Addressbook search" as of yet though.

Any update on how I could use this long awaited update to the LDAP_addressbook module ?

-Avinash

ashenoy’s picture

And then I found the "Search LDAP_addressbook" block. Works fine except for one small glitch. The search cannot recurse down a directory tree. For. e.g. if my LDAP structure is something like :

ou=foo,ou=bar,dc=blah,dc=com

As long as I plug the entire base "dn" into the addressbook search settings things work fine.

I want the addressbook lookup to point at ou=bar,dc=blah,dc=com

No go. A search does not return anything. Not even a error.

Any clues anyone ?

-Avinash

silvina’s picture

Hello,
I installed the modded ldap_addressbook on Drupal 5.7 with ldap_integration-5.x-1.3 and it works. But, it works OK on Mozilla, on Conqueror and on Safari on different operating systems. It doesn't work on Internet Explorer. Does anybody have the same problems? Do you know how to solve it?
Thanks,
Silvina

silvina’s picture

Hi,
The problem with Internet Explorer wasn't that it didn't work, but that the "enter" key didn't work. (I mean, the search worked only if the search button was pressed). I fixed this issue by adding on the function _ldap_addressbook_block_search():
$form['op'] = array('#type' => 'hidden', '#value' => t('Search'));
Regards,
Silvina

owahab’s picture

Status: Active » Needs work

Great job kmcnamee.
I am reviewing the code and so far it requires a lot of work.