The following errors were displayed when updating to 5.x-2.0:

* warning: array_merge() [function.array-merge]: Argument #2 is not an array in /var/www/vhosts/example.com/httpdocs/update.php on line 309.
* warning: Invalid argument supplied for foreach() in /var/www/vhosts/example.com/httpdocs/update.php on line 542.

CommentFileSizeAuthor
#2 patch_162.txt572 byteswebernet

Comments

aclight’s picture

aclight commented

I got the same errors in the same situation (upgrading from 5.x-2.0-rc2).

It looks like this is caused by update_status_update_5202() not returning anything (an array is expected). But I don't think the error message indicates any functional problem with the upgrade.

webernet’s picture

webernet commented
Status: Active » Needs review
StatusFileSize
new patch_162.txt572 bytes

Attached patch should fix the problem.

See: http://drupal.org/node/159757 for a similar issue...

dww’s picture

dww
we/he/they
commented
Status: Needs review » Active

grrrrrr :(

This is a bug in update.php. But, alas, I guess we need to fix it here for now. Thanks for the patch. Committed to DRUPAL-5--2.

I'd *hate* to make a 5.x-2.1 just for this. Maybe I'll make 5.x-2.0-2 or something, but that seems evil, too. *sigh*

I guess I could use my CVS super-powers and just move the tag on that one file and rebuild the tarball, since it's only been out for 9 hours, not *that* many people must have gotten it yet. ;)

I'll leave this issue open as "active" until I (and merlin, if he's around) decide what to do in terms of the release. Stay tuned.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Well, the count of people who have gotten it just went up by one...

dww’s picture

dww
we/he/they
commented

See http://drupal.org/node/167610 about fixing this in core.

misterlawrence’s picture

misterlawrence commented

I'm fairly new to Drupal, so I am not sure if I should be concerned now that I have received these error messages.

So two quick questions:

  • Should I continue to use the latest update (error message and all) and await a newer version to correct the error?
  • Or should I roll back to my backup database and 5.x-2.0-rc2 and await a newer version?

I am too much of a newbie to apply a patch...

Thanks.

-David

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Active » Fixed

After getting some input via IRC, I decided to just move the DRUPAL-5--2-0 tag on this 1 file, rebuild the tarball, and added a note at the bottom of the release notes about it:

Note: for the first few hours of its existance, this release had a minor problem where database update 5202 would generate some warning messages on sites using PHP5. These warnings are harmless, and can be safely ignored. However, to avoid confusion and support requests, this problem has been fixed in the tarball with "7a529169eae6cc8b2a1a610157695ca5" as the md5sum.

I just ensured that the tarball was rsycn'ed all the way to ftp.d.o, so I think everything's cool now.

@misterlawrence: The relevant phrase from that note for you is: "These warnings are harmless, and can be safely ignored.". ;)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)