Remove button broken if form is rebuilt (via ajax or failed validation)

Wrong project, moving.

The same I experience. I have own ajax functionality in my form_alter function. Maybe it collides somehow with the field collection ajax call. I for my part get an answer from the ajax call but the changes aren't reflected in the browser. Tomorrow I will examine it further.

The problem seems to occur because of a html-id in my form, which doesn't correspond to the html id of the field collection. The module clears the id's cache in it's callback function for remove:

  // drupal_html_id() very helpfully ensures that all html IDS are unique
  // on a page. Unfortunately what it doesn't realize is that the IDs
  // we are generating are going to replace IDs that already exist, so
  // this actually works against us.
  if (isset($_POST['ajax_html_ids'])) {
    unset($_POST['ajax_html_ids']);
  }

The callback trys to replace the content of a html element with id edit-field-invitee but in the html of my form the element is attributet with the an id of edit-field-invitee--2.

I am having the same issue, but its independent of the 'unlimited values' setting.

Let me know if you guys find the solution.

Thanks,
Prateek

I too have encountered this issue and have fixed it (at least for now). The solution is somewhat of a hack. I pull out the actual id from the POST 'ajax_html_ids' array and do the ajax commands using it. Like I say in my comment, I'm sure this could be done better. I am not that familiar with core D7 ajax stuff yet and I'm in a hurry. I'm using a bastardized version of Field Collection because I require Field Collection Table support, so a patch would be kind of useless. Here's my whole function field_collection_remove_js():

<?php
function field_collection_remove_js() {
  // drupal_html_id() very helpfully ensures that all html IDS are unique
  // on a page. Unfortunately what it doesn't realize is that the IDs
  // we are generating are going to replace IDs that already exist, so
  // this actually works against us.
  $ajax_html_ids = array();
  if (isset($_POST['ajax_html_ids'])) {
    $ajax_html_ids = $_POST['ajax_html_ids'];
    unset($_POST['ajax_html_ids']);
  }

  list($form, $form_state) = ajax_get_form();
  drupal_process_form($form['#form_id'], $form, $form_state);

  // Get the information on what we're removing.
  $button = $form_state['triggering_element'];
  // Go two levels up in the form, to the whole widget.
  $element = drupal_array_get_nested_value($form, array_slice($button['#array_parents'], 0, -3));
  
  // Check 'ajax_html_ids' to make sure we are using the actual id. I'm sure this could be done more cleanly.
  $actual_id = $element['#id'];
  foreach ($ajax_html_ids as $key => $id) {
    if ($id == $element['#id'] || strpos($id, $element['#id'] . '--') === 0) {
      $actual_id = $id;
      break;
    }
  }
  
  // Now send back the proper AJAX command to replace it.
  $return = array(
    '#type' => 'ajax',
    '#commands' => array(
      ajax_command_replace('#' . $actual_id, drupal_render($element))
    ),
  );

  // Because we're doing this ourselves, messages aren't automatic. We have
  // to add them.
  $messages = theme('status_messages');
  if ($messages) {
    $return['#commands'][] = ajax_command_prepend('#' . $actual_id, $messages);
  }

  return $return;
}
?>

If you get form via ajax, there is another solution.
I get hint from somewhere but i can not remember exact issue number.
but key is this.
in field_collection_remove_js function,
required inc file is not included if the parent of field collection is node type.
So, If you get a form by using ajax, you have to add required resources after calling ajax_get_form

function field_collection_remove_js() {
  // drupal_html_id() very helpfully ensures that all html IDS are unique
  // on a page. Unfortunately what it doesn't realize is that the IDs
  // we are generating are going to replace IDs that already exist, so
  // this actually works against us.
  if (isset($_POST['ajax_html_ids'])) {
    unset($_POST['ajax_html_ids']);
  }

  list($form, $form_state) = ajax_get_form();
  // Include required files to process form actions
  if ($form['#entity_type'] == 'node') {
    module_load_include('inc', 'node', 'node.pages');
  }
  
  drupal_process_form($form['#form_id'], $form, $form_state);

  // Get the information on what we're removing.
  $button = $form_state['triggering_element'];
  // Go two levels up in the form, to the whole widget.
  $element = drupal_array_get_nested_value($form, array_slice($button['#array_parents'], 0, -3));
  // Now send back the proper AJAX command to replace it.
  $return = array(
    '#type' => 'ajax',
    '#commands' => array(
      ajax_command_replace('#' . $element['#id'], drupal_render($element))
    ),
  );

  // Because we're doing this ourselves, messages aren't automatic. We have
  // to add them.
  $messages = theme('status_messages');
  if ($messages) {
    $return['#commands'][] = ajax_command_prepend('#' . $element['#id'], $messages);
  }

  return $return;
}

#5 is unrelated to this issue, that's just because you should have used form_load_include() instead.

#4 is along the right lines, but is a brittle hack, and will not work in all cases.

This is equally hacky, but also works for AJAX as well as failed validation.
Because of #1575060: ajax_html_ids are broken for forms with file element (encoding=multipart/form-data), the structure of $_POST['ajax_html_ids'] is variable.

Basically, unless drupal_html_id is not used on forms, or unless *every AJAX callback* uses the unset($_POST['ajax_html_ids']) hack, we need to code around this somehow.

For my use case, #1315900: Ctools Modal form's #id changes when validation fails actually solves the problem as well.

We likely need some core documentation that any AJAX callback that is doing form processing must unset the ajax_html_ids first.

I made a content type with a field collection (unlimited cardinality) that contains a text field and a file field. The content type also has its own file field.

I created a node with a bunch of field collection items with sequential values in their text fields. I edited it several times trying things like adding items and uploading files and then deleting some field collection items and then submitting the form. I didn't see anything strange happening.

What exactly is the problem behavior and how can it be duplicated?

To duplicate, you need to make your form AJAX. Select the add button to add another one of the fields and they press submit with a validation error. In your AJAX callback, return the complete form. Now try to remove one of your fields with the remove button. It will fail.

I have applied the patch and my form is now working as expected.

Works for me, Thanks!

I propose patch based on using Drupal AJAX API.

It fills proper element id in 'wrapper' key of element '#ajax' property. AJAX callback was changed from page callback to ajax callback, using function field_add_more_js() as example for callback.

I have a problem removing fc items but I'm not sure if is exactly the same. For any reason, the remove button don't work and I don't know exactly why. I searched and I found several issues related with field collection removing proccess.

@dewalt This patch is work for me and resolve my problem, but like I said, I'm not sure if is the same problem, a similar problem or if it's completely different.

but... really thanks!!!!! :-)

I have what might be a different problem (that I thought might be related) where the remove button always removes the last item from the field, regardless of which row you click remove on. Applying this patch broke the module even further so that now none of the buttons do anything.

@rlmumford - As I understood, the problem is:

the remove button always removes the last item from the field, regardless of which row you click remove on.

This works correctly on my project, where the patch used.

Can you please provide more details, about module broke with patch? What version of module you patched? Were additional modules installed, that depend on field_collection?

Ah, my issue was this one.

#2456307: Item Remove Button confuses #parents and #array_parents

Patch #12 works for me.

Patch #12 worked for me

Patch #12 worked for me to

Patch #12 worked for me to

I think that it's RBTC, 4 reviewer is enough.

Patch works for me; the issue in #15 did not happen on my site. Please commit.

I need this for beta5 module, here is the patch

Update the patch file name

Re-uploading working patch.

Thanks!

Still experiencing problems with AJAX deletion, this code patches 7.x-1.0-beta11.