Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Trivial patch, hence marked as RTBC.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | privatemsg.module.167573.patch | 1.45 KB | jaydub |
| #3 | privatemsg.module.167573.patch | 1.48 KB | jaydub |
| write_to.patch | 692 bytes | wim leers |
Comments
Comment #1
Zen commentedI don't really see anything wrong with using "author". Even if such a modification is to be made, it should probably use theme_username.
Please don't set issues to RTBC directly regardless of their triviality.
My inclination is to "by design" this.
-K
Comment #2
wim leersMy apologies for marking it as RTBC. I'm not sure why I did that.
"author" is a word that's uncommon lingo in certain use cases, such as forums. "user" would be more common there. As a way in-between, I opted for "Write to John Doe".
In hindsight, this should have been made configurable through the admin settings. I.e. allow the administrator to use a fixed piece of text (allowing for "author", "user", whatever), or the recipient's name.
Comment #3
jaydub commentedMy take on this in patch form...
includes administrative option to use the default or the username.
Comment #4
wim leersThanks.
This line definitely needs work:
'title' => variable_get('privatemsg_write_to_default', 'default') == 'username' ? $link_text = t('Write to @name', array('@name' => $author->name)) : $link_text = t('Write to author'),At least remove the
$link_text =pieces, since they're useless.Comment #5
jaydub commentedoops that was left over from a previous pass! Aside from that what else
needs work?
Comment #6
wim leersThe rest seems ok to me :)
Comment #7
jaydub commentedre-roll of patch
Comment #8
wallbay1 commentedvery nice patch but how do I paste it on the site
which folder etc..
Comment #9
wim leersThe Drupal 5 version of this module is no longer maintained.