It is a widely used standard that the AJAX loaded content could be closed on clicking on the overlay or on the page content. When the item title is not display, this option gives users a more intuitive way to close the item.

CommentFileSizeAuthor
#3 taskbar-click_close-1676364-1.patch424 bytesmahtoranjeet

Comments

jcisio’s picture

jcisio commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mahtoranjeet’s picture

mahtoranjeet commented
Status: Closed (fixed) » Needs review
StatusFileSize
new taskbar-click_close-1676364-1.patch424 bytes

I had created an issue for this feature http://drupal.org/node/1786376.
Found this issue so close that one was duplicate.

I saw the setting was already added but the JS was not working properly. fixed the js code.

jcisio’s picture

jcisio commented
Status: Needs review » Needs work

Ok, it does not work if the autoclose option is not enabled. Thus we could either modify Drupal.taskbar.closeAll to bypass that check, or copy logic in that function (removeClass('taskbar-item-active') when an item is closed).

mahtoranjeet’s picture

mahtoranjeet commented

Could you test this again

I have tested this with autoclose option disabled. It is working fine for me.

jcisio’s picture

jcisio commented

I meant the current code. About the patch, it does not remove the class (what is said in #4).

jcisio’s picture

jcisio commented
Status: Needs work » Fixed

Fixed with http://drupalcode.org/project/taskbar.git/commit/1f08d83 (D7) and http://drupalcode.org/project/taskbar.git/commit/83dc47d (D6).

mahtoranjeet’s picture

mahtoranjeet commented

Great

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.