When adding a new search environment at admin/config/search/apachesolr/settings, the user is redirected to admin/config/search/apachesolr when they click the "Cancel" link which is not the page they came from.

CommentFileSizeAuthor
#6 1677050-6.patch2.45 KBnick_vh
#5 1677050-5.patch2.86 KBnick_vh
#1 cancel-link-target-1677050-1.patch484 bytescpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new cancel-link-target-1677050-1.patch484 bytes

Attached patch changes the default destination of the cancel link.

pwolanin’s picture

pwolanin commented
Version: 7.x-1.0-rc2 » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

committed to 7.x - is the link wrong in 6.x-3.x?

killua99’s picture

killua99 commented
Status: Patch (to be ported) » Needs review

The redirect it's ok but if you didn't complete all the form the validation "required" fields jumps and don't allow you to cancel it without put any on those fields.

cpliakas’s picture

cpliakas commented

Not following what you are saying.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
StatusFileSize
new 1677050-5.patch2.86 KB

Cancel links in D6 are devilish! So I changed all of the cancel buttons to links to prevent hacky solutions like this one http://devengineering.com/best-practices/drupal/cancellation-required-va...

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
StatusFileSize
new 1677050-6.patch2.45 KB

no need for a theme function

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.