Here are some modifications I made to the module to allow customization of the Twitter handle input into the st_via option.

CommentFileSizeAuthor
#6 sharethis-1677262-6.patch535 byteschi
sharethis.patch1.87 KBspacegoat1701

Comments

robloach’s picture

robloach
he/him
commented
Status: Active » Fixed

Thanks http://drupalcode.org/project/sharethis.git/commit/4db1602

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

klucid’s picture

klucid commented

This great, thank you. Is there a way we can have a patch that also includes the option to remove the Twitter handle completely? Leaving this field blank defaults to "@ShareThis".

Thank you!

klucid’s picture

klucid commented
Version: 7.x-2.4 » 7.x-2.5
Category: task » feature
Status: Closed (fixed) » Active
robbe-1’s picture

robbe-1 commented
Title: Allowing customization of Twitter handle » Allowing empty Twitter handle
Priority: Normal » Major

This is kind of major to me. This should be one of the first things to implement. Or am I wrong?
I will have to 'hack' the module since I don't have time to wait now, but for future use, this would be very handy.

chi’s picture

chi commented
Version: 7.x-2.5 » 7.x-2.x-dev
Assigned: spacegoat1701 » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new sharethis-1677262-6.patch535 bytes

The patch allows to submit empty twitter_handle which in turn removes "via @sharethis".

Status: Needs review » Needs work

The last submitted patch, 6: sharethis-1677262-6.patch, failed testing.

navneet0693’s picture

navneet0693 commented
Status: Needs work » Reviewed & tested by the community

Clear to go !

The last submitted patch, sharethis.patch, failed testing.

purushotam.rai’s picture

purushotam.rai commented
Status: Reviewed & tested by the community » Patch (to be ported)

  • purushotam.rai committed c9fabd1 on 7.x-2.x authored by Chi 
    Issue #1677262 by Chi, navneet0693, purushotam.rai: Allowing empty...
purushotam.rai’s picture

purushotam.rai commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.