Remove drupal_deliver_page(), ajax_deliver(), drupal_deliver_html_page()

I hope I did this right...

Let's ask the bot.

Hm. I didn't remove the 4 string references to ajax_deliver(). What do we do with those?

If the function never gets called anyway, we may as well just remove them. In fact, the entire delivery callback can be purged entirely. Everything is now done via mime type.

That's usually where I get confused. It *looks* like all of ajax_test.module would need to go away, and the reference in file_menu(). I would assume the body of hook_page_delivery_callback_alter() would be empty too?

Removed additional function references, but not those in ajax_test.module.

hook_page_delivery_callback_alter() probably goes away entirely, since there's nothing for it to alter.

I don't think ajax_test.module goes away, as FrameworkTest is still using it. It's just detecting based on the mime type now. However, the delivery callback lines in its hook_menu() should get removed, as should the references in file_menu() and anywhere else that they appear.

Removed additional references.

Run Drupal\field\Tests\FormTest and check the verbose output. Where HTML is expected something is not so: simplexml_import_dom(): Invalid Nodetype to import

Did that...but the results aren't making any sense to me...

I'm planning to replace that table entirely anyway, so I don't much care if we drop that field now or not.

Then #12 looks done to me. Yay for patches with lots of minus signs! :-)

Shouldn't there be an update func to drop the delivery_callback column from the menu_links table ?

Nicey. :)

#12: 1677304-remove-delivery-12.patch queued for re-testing.

Asking for a re-test as the patch don't seem to apply for me.

The re-rolled patch is missing code removals from menu.inc, system.api.php, system.module, and system.install.

Committed to 8.x. Win! :)

This was a fairly big change, and it was very unclear what to do to deal with these being replaced.

No change notification or further work materialized in #1622934: Replace delivery callbacks by leveraging the HTTP kernel, fix the overlay module and it was rescoped to fix follow bugs, but the change notice is still not done.

This has been waiting for a change notice for over 6 weeks now. Let's please get this knocked out.

Added change notice here: http://drupal.org/node/1937056

It could probably stand some revising, but if you (the royal you) think it's good enough for now, go ahead and mark this issue fixed.

@Crell, thanks. It does not seem to be enough for me to understand how systems using the prior functionality should now adapt. Which is the purpose of the change notice :) Eg. how would #1848210: [Tests] Submitting a form in Overlay shows content + dsm() for a split second before redirecting to front-end theme be possible to resolve is one thing I expected to learn from here, since that is a use case where core still attempts to use the non-existent functionality.

My knowledge of overlay is minimal at best, so I don't really follow what's going on in that issue. If you could explain (probably there, not here) what exactly that has to do with drupal_deliver_page() I might be able to say something intelligible on the subject, and figure out what the appropriate "modern" alternative is. (Which would help with a more useful change notice.)

Done: http://drupal.org/node/1848210#comment-7150930

I'm working on updating the change notification and specifically reviewing the overlay issue to see if I can figure out something coherent. Thanks!

I've updated the change notice here http://drupal.org/node/1937056. Specifically, I discussed how (I guess) one can achieve the functionality of hook_page_delivery_callback_alter() by creating an event listener for "onRequestSetController".

#38 looks good
back to fixed and fixing title
thanks!