To follow Drupal conventions and English norms, all phrases that are not proper nouns should only have the first words capitalized. In this module, "Street Continued" should be "Street continued", and "Apt/Suite#" should be "Apt/suite#".

"Apt/Suite#" probably should not have the pound sign. Spell out number.

It's not clear what the "Other" field is used for.

It's not clear whether "Street" is supposed to contain the entire street address or just the number.

"Street" may be a confusing name when non-street addresses are used, like PO BOX. How about "Address line 1" instead?

"Apt/Suite#" only makes sense in the context of the street address, so it should be at the end of the address first line and not on its own line. In the same sense, you have city, state, ZIP, and country on the same line.

Comments

rconstantine’s picture

Category: bug » support
Status: Active » Fixed

Again, this isn't a bug. Modify the code to suit your needs, that's why it's open source. Or use the translation module.

aren cambre’s picture

Category: support » bug
Status: Fixed » Active

No, the base version of anything needs to be clean and understandable. It's minimally a user interface bug.

If you mark this as fixed again without fixing or addressing the problems (beyond saying "fix them yourself"), then you are basically saying you have little concern for the quality of your work.

moshe weitzman’s picture

These seem like good suggestions to me. At minimum, the capitalization recommendations are required for consistency with Drupal guidelines.

rconstantine’s picture

Assigned: Unassigned » rconstantine
Status: Active » Fixed

Will be in next release.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.