It would be nice if omega allows subthemes to make themselves recolorable with the color.module.

Stylesheets that are added with the non-standard (!?) css[global.css] format in theme's .info files are not substituted with the recolored files the page's array of CSS files.

This patch fixes that by substituting the omega-stylesheets too. It was rolled against version 3.1.

CommentFileSizeAuthor
#7 1677540-7-omega_color_module_support.patch3.42 KBfastangel
#1 1677540-1-omega_color_module_support.patch3.49 KBmrfelton
omega_color_module_support.patch3.34 KBBevan

Comments

mrfelton’s picture

mrfelton commented
Status: Active » Needs review
StatusFileSize
new 1677540-1-omega_color_module_support.patch3.49 KB

I think there was a slight error with the previous patch, as the replacements were only done if there was at leaset one stylesheets declaration in the .info file, which is often not the case with omega themes.

Status: Needs review » Needs work

The last submitted patch, 1677540-1-omega_color_module_support.patch, failed testing.

iztok’s picture

iztok commented

Integrating Omega with Color module is very confusing for me.

As I understand it can be done without this patch, but then you need to declare:
stylesheets[all][] = css/styles.css

Anyway, I used this patch and it does rewrite my color.css file but I also get:

Notice: Undefined property: stdClass::$stylesheets in _color_html_alter() (line 93 of /xxx/modules/color/color.module).
Warning: Invalid argument supplied for foreach() in _color_html_alter() (line 93 of /xxx/modules/color/color.module).
iztok’s picture

iztok commented

Sorry, this was my mistake, I called _color_html_alter($vars); from alpha_process_html(&$vars) even though I was in a subtheme.

liakoni’s picture

liakoni commented
Status: Needs work » Needs review

#1: 1677540-1-omega_color_module_support.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1677540-1-omega_color_module_support.patch, failed testing.

fastangel’s picture

fastangel commented
Status: Needs work » Needs review
StatusFileSize
new 1677540-7-omega_color_module_support.patch3.42 KB

And update the patch to pass test and some warnings.