Node not saved when hook_node_insert() or hook_node_update() are invoked

Moving to D8 first.

I actually think this is major, if only to add the documentation.

hm, this also relates to #1729812: Separate storage operations from reactions.

Given #1729812: Separate storage operations from reactions I think the transaction should be completed *before* the hooks are invoked, thus making the hooks for reactions only. We can't do that for d7, but for d8 we could. I guess this would deserve its own issue though and require field-storage to be moved to the entity controller (and separately re-usable) first.

There is no patch on this issue, so reverting status to "active".

At the moment, the process would be to fix the D8 docs here, then backport the changes to D7. That other issue may or may not be resolved any time soon.

Thanks, looking pretty good!

There shouldn't be a comma here though (the first one):

+ * Note that at the time, when this hook is invoked, no changes were actually
+ * written to the database. This will be done when save operation is entirely

Actually, I think it needs a little rewriting to make more sense grammatically. How about something more like:

Note that when this hook is invoked, the changes will not yet be written to the database, because a database transaction is in progress. The transaction is not finalized until...

Also, this section has some extra commas and needs rewriting:

* the database at this time as it may be out of date. You should also note,
+ * that any write/update database queries, that will be run from this hook,
+ * will also not be committed immediately. Check node_save() and

Much better, thanks! There are still a couple of small comma/article problems to fix:

+ * Note that when this hook is invoked, the changes will not yet be written to
+ * the database, because a database transaction is in progress. The transaction is
+ * not finalized until save operation is entirely completed and node_save() goes
+ * out of scope. You should not rely on data in the database at this time as
+ * it may be out of date. You should also note that any write/update database
+ * queries, executed from this hook, will also not be committed immediately.
+ * Check node_save() and db_transaction() for more info.

- 3rd line: "...until *the* save operation..."
- 5th line: I don't think the information is really "out of date", it's just not updated yet?
- 6th line: Remove both commas

Also... The previous paragraph to this text that is added reads:

This hook is invoked from node_save() after the node is updated in the node table in the database, after the type-specific hook_update() is invoked, and after field_attach_update() is called.

So this second paragraph contradicts the first one and the first one is really incorrect, right? Something needs to be done about that... maybe integrate them together?

I think the new wording is OK. The only thing I think needs to be fixed now is that the verb tenses documentation are inconsistent, which makes it a bit confusing (it switches between past, present, and future). And there is one missing "the" in the new text: "... that will insert *the* node into...". Other that that, I think it's OK.

Better, thanks! There are still a few small errors that need to be fixed:

a) The word wrapping on this line is too long:

+ * insert the node into the node table is scheduled for execution, after the type-specific

I think there are a couple others that are longer than 80 characters too.

b) Grammar problem:

+ * Note that when this hook is invoked, the changes has not yet been written to

changes *have* not yet... ... This grammar needs to be corrected in several places in the patch.

Thanks! Assuming the test bot shows green (which it should), I'll get this committed shortly (patch will most likely work for both 8.x and 7.x).

Committed to 8.x and 7.x. Thanks again for *your* time and effort!