The content type variable, "attachment_links_selection_[content-type]" exports via features (strongarm) as a numeric field ID. This causes the variable to be off when the field ID isn't the same.

To reproduce, export the attachment_links variable into a site with a different number of fields.

CommentFileSizeAuthor
#2 numeric-to-field_name-1678140-2.patch5.72 KBultimateboy

Comments

ultimateboy’s picture

ultimateboy commented

In my specific instance, I can require that this feature be installed within my installation profile and thus have control of the field's numeric ID. But, this isn't always possible and it would definitely be nice to use the field name instead of the ID.

ultimateboy’s picture

ultimateboy commented
Status: Active » Needs review
StatusFileSize
new numeric-to-field_name-1678140-2.patch5.72 KB

I've gone ahead and changed this variable to use the field name instead of the field ID, which I think is much better for feature exports as well as a lot of other things. I wrote an update function to transition previously numeric variables to their field name as well. Patch attached.

ultimateboy’s picture

ultimateboy commented
Title: Content type variable "attachment_links_selection_[type]" exports to features as numeric field ID » Variable "attachment_links_selection_[type]" stores numeric field ID instead of field name
drinkdecaf’s picture

drinkdecaf commented

Misspoke. Patch seems to play nice w/ features.

ultimateboy’s picture

ultimateboy commented

drinkdecaf, so much so that you're willing to mark RTBC?

rupl’s picture

rupl
he/him
Primary language English
commented
Status: Needs review » Fixed

This has been committed to dev. Thanks for the solid patch!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.