Hi all,

I think about one thing that could be very usefull for recipe module.

For a lot of recipe website, ingredients needs to link on another node of the website. In my case, I sell some ingredients needed in the recipes I propose so when I put na ingredient I sell on my recipe, I need to link on it.

What about add this functionnality for this great module, it could be like nodereference of CCK but for ingredients. The major difference is that an ingredient is not obligatorily a node reference.

CommentFileSizeAuthor
#8 recipe-ingredients-as-node-reference-install-167830-7.patch117 byteswwmv
#6 recipe-ingredients-as-node-references-167830-6.patch2.5 KBwebchick
#5 recipe-ingredients-as-node-references-167830-5.patch1.58 KBwebchick
#1 recipe.module_0.patch112.11 KBzmove

Comments

zmove’s picture

zmove commented
Status: Active » Needs review
StatusFileSize
new recipe.module_0.patch112.11 KB

I find a solution to the problem so I post it as a patch.

Feature description :

When adding a new recipe, the module now check on database if there is a node that have the exact title of one ingredient. If yes, he register the node id into a new column named "link" in {recipe_ingredient}.

When showing the recipe, the module now check if there is a node id in the link column. If yes, it create a link on this node.

I have problem to create patch so I upload all the recipe.module, if somebody can make it a patch it could be great (patch creation bug on my nasty windows computer...)

As I said, this modification require a new column on the {recipe_ingredient} table, to add it just put this code on your SQL textarea (using phpmyadmin) (don't forget to add prefix if you have one)

ALTER TABLE `dp_recipe_ingredient` ADD `link` SMALLINT UNSIGNED NOT NULL ;
nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

The "correct" way to add a column is to add a recipe_update_xxxx function to the recipe.install code. It is very simple.

brdwor’s picture

brdwor commented
Status: Needs review » Needs work

I like this idea. Please upload a reciple.module file if you can not create a patch. Also, needs a modified recipe.install.

zmove’s picture

zmove commented

I already uploaded the recipe.module modified above...

I modify a lot of things on my recipe.module after this modification so I can reupload it anymore. If the patch above is not good, I will try to create another with just the node reference modification, but later, my deadline approach and I don't have time for now.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new recipe-ingredients-as-node-references-167830-5.patch1.58 KB

Ok, I *think* this is the original patch... I copy/pasted the + lines of the patch above (which seemed to be the entirety of the .module file), and then pasted that over a checkout of recipe.module from August 6, and cleaned up a few coding style things.

I'm not sure i this patch is the optimal way to solve this, but at least it can now be properly reviewed. I'll roll in the update path to add the column when I get home later.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new recipe-ingredients-as-node-references-167830-6.patch2.5 KB

Here's the full thing, with the upgrade path.

marble’s picture

marble commented
Status: Needs review » Fixed

Applied the patch, thankyou.

wwmv’s picture

wwmv commented
Category: feature » bug
Priority: Normal » Critical
Status: Fixed » Active
StatusFileSize
new recipe-ingredients-as-node-reference-install-167830-7.patch117 bytes

The patch introduced a new db table cell 'link' (recipe_ingredient table) in .module but did not change the .install file correct. The bug occurs when the module is installed the first time.

The exact error is:
user warning: Unknown column 'i.link' in 'field list' query: recipe_load_ingredients SELECT ri.id, i.name, i.link, ri.quantity, ri.unit_id, u.abbreviation, ri.ingredient_id FROM _v1recipe_node_ingredient ri, _v1recipe_ingredient i, _v1recipe_unit u WHERE ri.ingredient_id = i.id AND ri.unit_id = u.id AND ri.nid=1114 ORDER BY ri.id in /var/www/drupal-5-2/includes/database.mysql.inc on line 172.

To fix this just insert the 'link' entry in hook_install, {recipe_ingredient}. I tried to come up with a patch but I'm new to this.

marble’s picture

marble commented
Status: Active » Fixed

Thanks. I'm afraid I didn't notice you'd attached a patch until after I'd checked in the change, so didn't credit you in the checkin comment, but your patch was appreciated and I made pretty much the same fix you had in the patch (but for the pgsql version too).

Hopefully the current version will work for people's new installs as well as upgrades. Sorry about the problems!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.