Not all users like admin.module so it would be nice to maintain a menu with administrative conference tasks independent of the admin module. That way suers can choose whatever module they like to provide an admin UI.

Suggest defining the conference admin menu in cod_base and adding menu links to it in individual addon features.

CommentFileSizeAuthor
#17 cod-base-admin-depend-1679940-17.patch4.38 KBtwardnw
#14 cod-base-admin-depend-1679940-14.patch643 bytesdsdeiz
#8 cod-base-admin-depend-1679940-8.patch1.63 KBdsdeiz
#4 cod-base-admin-depend-1679940-4.patch6.43 KBcafuego
#1 1679940-remove-admin-module-depend-1.patch8.27 KBcafuego

Comments

cafuego’s picture

cafuego commented
Status: Active » Needs review
StatusFileSize
new 1679940-remove-admin-module-depend-1.patch8.27 KB

Attached patch removes the dependency on admin.module and defines menu-conference-administration.

ezra-g’s picture

ezra-g commented

I'm fine not making the Admin module a requirement as long as it's enabled by default on fresh installs.

Looks like that's taken care of for us in the .profile:

In COD 6.x the machine name for this menu was menu-conference-admin. If there's not a specific reason to depart from that, I suggest we stick with it. There's not an explicit upgrade path between 6.x and 7.x, but would simplify the task of providing one if somebody wanted to work on that. It's also a shorter name.

cafuego’s picture

cafuego commented
Status: Needs review » Needs work

Ah, I didn't think to check the name in D6. Will reroll a patch with 'menu-conference-admin'.

cafuego’s picture

cafuego commented
Status: Needs work » Needs review
StatusFileSize
new cod-base-admin-depend-1679940-4.patch6.43 KB

Rerolled patch with renamed menu.

primerg’s picture

primerg commented
Issue tags: +da_drupalcon

tagging

primerg’s picture

primerg commented

tested the patch and it admin is not automatically enabled. also saw an empty "Conference Admin" menu.

twardnw’s picture

twardnw commented

cafuego, could you apply #1477754: Rename "site administrator" role to "administrator" and re-roll your patch? :) The direction we are heading with the 'Conference Administrator' role is causing some conflicts.

dsdeiz’s picture

dsdeiz commented
StatusFileSize
new cod-base-admin-depend-1679940-8.patch1.63 KB

Patch attached that removes admin.module dependency and creates "Conference Admin" menu. Diff is after applying patch from #1477754: Rename "site administrator" role to "administrator".

twardnw’s picture

twardnw commented

Indeed, patch applies clean and functions properly after applying
#1477754-21: Rename "site administrator" role to "administrator"

sheldonkreger’s picture

sheldonkreger commented

I agree. #8 works when used in conjunction with #1477754-21: Rename "site administrator" role to "administrator"

cafuego’s picture

cafuego commented

It looks like strongarm and the admin_toolbar setting are still in, but they are no longer required.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

#8 applies cleanly to sandbox using the following patch workflow:

#1477754-21: Rename "site administrator" role to "administrator" ->
#1679940-8: Remove admin.module dependency

twardnw’s picture

twardnw commented
Status: Needs review » Reviewed & tested by the community

3 clean test, I'd consider that RTBC

dsdeiz’s picture

dsdeiz commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new cod-base-admin-depend-1679940-14.patch643 bytes

As per #11, patch removes strongarm dependency and admin_toolbar var. This is a diff from the latest copy in sandbox.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Needs review » Reviewed & tested by the community

#14 applies cleanly to sandbox and removes the dependency on admin.module, defines menu-conference-administration, and shows no strongarm dependency or admin_toolbar variable.

ezra-g’s picture

ezra-g commented
Status: Reviewed & tested by the community » Needs work

#1668908: Replace User reference, Nodereference with References, Vertical session schedule view re-introduced strongarm as a dependency to cod_base.

twardnw’s picture

twardnw commented
Status: Needs work » Needs review
StatusFileSize
new cod-base-admin-depend-1679940-17.patch4.38 KB

Patch removes dependencies and permissions for admin.module

Do we want to handle the webform dependency in this patch too?

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Fixed

Removed from the cod_base

Automatically closed -- issue fixed for 2 weeks with no activity.