A user of my forum has been posting a lot of ASP problems (mixed in with some bad html), the codefilter module interprets this as PHP. This causes problems with the rendering of the site and messes up the code entered.

The codefilter module should ignore <% %> tags.

CommentFileSizeAuthor
#6 php_highlight_withsettings.patch2.11 KBliam mcdermott
#2 php_highlight_0.patch1011 bytesliam mcdermott
#1 withouttags.png85.9 KBliam mcdermott
withtags.png70.35 KBliam mcdermott

Comments

liam mcdermott’s picture

liam mcdermott commented
StatusFileSize
new withouttags.png85.9 KB

How the same code looks with < % % > matching removed.

liam mcdermott’s picture

liam mcdermott commented
Status: Active » Needs review
StatusFileSize
new php_highlight_0.patch1011 bytes

A patch to fix the problem.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Priority: Minor » Normal
Status: Needs review » Needs work

I think ASP-style and short tag-style escapes are a bad idea. But rather than removing the ability to highlight them, we should add an option to the filter to allow/disallow these tag styles.

liam mcdermott’s picture

liam mcdermott commented

JohnAlbin: if I create a patch to do this would you be able to commit it? Is someone maintaining this module?

Sorry, just don't want to do work for it to fall down a black hole. :)

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

I don’t have commit access for this module. But if you post a patch, I’ll review it.

Also, I’m pretty sure that if a patch gets reviewed and marked RTBC, that Steven will review it and decide whether to commit it. This module is pretty important to the Drupal.org website and most certainly is being maintained.

liam mcdermott’s picture

liam mcdermott commented
StatusFileSize
new php_highlight_withsettings.patch2.11 KB

Sorry for not having followed-up on this sooner. Attached is a patch that adds the option to switch off ASP-style filtering to the filter Configure tab. ASP-style filtering is on--which is the module's current behaviour--by default.

liam mcdermott’s picture

liam mcdermott commented
Status: Needs work » Needs review
sepeck’s picture

sepeck commented

You may want to test to see if this issue occurs on Drupal 6 beta's as well,. Code filter has been moved into core with Drupal 6. If it is an issue, then file a separate bug report.

chx’s picture

chx commented

Yes likely D6 suffers from this but I have no problems just ripping out ASP tags support from codefilter as the PHP manual strongly discourages their use so it's quite expectable noone ever will post using those.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

I looked at Drupal 6 and, for the life of me, I could not find a "Code filter" input filter or anything like it. Care to enlighten me?

Liam, I'll review your patch tonight, if I can get to it.

cameron tod’s picture

cameron tod commented
Version: 5.x-1.x-dev » 6.x-1.0

Fixed in D6 here: http://drupalcode.org/project/codefilter.git/commit/d85f338c8571040cdb36...

cameron tod’s picture

cameron tod commented
Version: 6.x-1.0 » 7.x-1.x-dev
Status: Needs review » Needs work
cameron tod’s picture

cameron tod commented
Status: Needs work » Fixed

And in D7 here: http://drupalcode.org/project/codefilter.git/commit/a80798674b16b20b94f7...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.