"TYPES" is not a legal field name table "BLOCKS"

Changing Status to patch.

I guess we didn't catch this - the field wasn't orginally called types. Good eye.

andre

I suggest we name this field 'nodes'. Also, we'll need an upgrade path for those who are running CVS HEAD.

I'm a bit confused by this. The word "types" doesn't show up here:
http://dev.mysql.com/doc/mysql/en/reserved-words.html

I remembered seeing it here: http://drupal.org/node/2497 If this is incorrect, then the documentation needs to be changed.

But all in all, nodes isn't a bad idea - I can submit a patch along with the upgrade path if 'types' is indeed a reserved word in either mySQL or pgSQL.

andre

"TYPES" /is/ a reserved word in mysql 4.1.0 and 4.1.1. it doesn't show up at http://dev.mysql.com/doc/mysql/en/reserved-words.html because it isn't reserved anymore since some point release later. it isn't even documented in the mysql changelog that it has ever been a reserved word ...

once again the suggestion to get rid of sql reserved words issues once and for all

I'll submit a patch later today to use the word 'nodes' in block - along with the database upgrade path.

andre

Here is the patch to block.module

And the db files and upgrade path.

This column has been removed by http://drupal.org/node/21353. See differences at http://cvs.drupal.org/viewcvs/drupal/drupal/database/database.mysql?r1=1....