Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I've run into an issue where the fade / blend doesn't work with the 'dir=' attribute unless 'img=|(image path)|(somelink)||||,' is set.
if: 'img=||||||,' is set, then the 'dir=|', the fade doesn't work
if: 'img=|(image path)|||||,' is set, then the 'dir=|'', the fade doesn't work
BUT
if: 'img=|(image path)|(some_url_path)|||||,' is set, the fade works...
It's no problem to set an image up with a blank url or something, but this might cause folks endless time in trying to figure out why the fade isn't working if they only set the 'dir=|',
I also tested: 'img=|(image path)|||||,' WITHOUT 'dir=', and the fade did not work...
module version: 1.24
Drupal version: 5.2
Hope that's enough info!
Comments
Comment #1
brmassa commentedphilsward,
hmmm lets go:
1* why are you inserting "img=||||||," ? if there is no image, simply delete this tag. the "img" tag is not needed.
2* its a bit confusing examples. i ask you to post the real tests, ok?
regards,
massa
Comment #2
philsward commentedWell, I did as you said, took out the img="" tag, and guess what... no fade... lol
When I first posted this, I was messing around with it in a test environment, so my mind is a bit rusty on the workings of why I posted this in the first place. I think that what I was trying to get at, is the fact that the img='' tag HAS TO BE IN PLACE in order for the fade to work. On top of that, if you just set the img= or 'img=(image path)|||||', the fade won't work. The only way I was able to get the fade to work using the dir= tag, was to set the img= tag with a static image AND url path, as noted through the 'img=|(image path)|(some_url_path)|||||,'.
Here is my working fading code:
Here is my non-fading code:
Long story short, when using the dir= tag, img= tag MUST be in place with the image path and url path set.
Comment #3
alynner commentedI found that it worked without the img= tag, but I had to have something in DIR_LINK.
I didn't want it to link to anything, so I commented out the two lines for $output_link and $output_link2 (lines 225-226). That made it not fade again. I think your code relies on the style or ID of that link. Perhaps you should just scrap "and $ss[$i]['link'] != 'javascript: void(0);'" from the if statement on line 224?
I don't like that its still a link though, so I just deleted the href from the link (on line 225) because I know I don't want them to be links anywhere in my site and it works all great.
cheers
alynner
Comment #4
brmassa commentedGuys,
its fixed. It will be on the next version (only for D6)
regards,
massa
Comment #5
hanskuiters commentedToo bad it can't be fixed for D5 , since it's an old bug.
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #7
meeotch commentedSorry to re-open this... just wondering if there's any chance you could point me at the broken code, so I can try to fix this for Drupal 5? I think it's a great module (thanks!), but there's unfortunately no chance that I can update my entire site to Drupal 6 just to continue using it. (As I mentioned, I'll try to make the fix myself... just hoping you can point me in the right direction.)
Comment #8
brmassa commentedmeeotch,
im afraid to say that i wont support D5 versions anymore. I changed the API deeply on D6 and i simply dont have the time to maintain 2 different versions.
im really sorry.
regards,
massa
Comment #9
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #10
ijustlost commentedSorry to re-open this yet again. I've just spent over an hour trying to get fade to work before I saw this post. Could you at least note this in the known issues section of the readme. You could just link to this page - I'm sure this would save a lot of peeps a lot of time!
Cheers,