Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up
Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options:
/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global Drupal, jQuery */
Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.
Files: progress.js
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | core-jshint-progress.js-1684806-4.patch | 402 bytes | nod_ |
Comments
Comment #1
nod_Missing a capital for
progressBarsince it is a constructor. JSHint doesn't catch it but it needs to be fixed.Comment #2
nod_Touches several files and is not a JSHint error since Drupal does have a capital letter even if it's not really the constructor.
See: #1684906: Drupal.progressBar is a constructor, rename it Drupal.ProgressBar
Comment #3
nod_New JSHint config #1995996: Update JSHint configuration.
core/misc/progress.js: line 16, col 9, 'pb' is defined but never used.Comment #4
nod_Comment #5
droplet commentedComment #6
alexpottCommitted cc71d8d and pushed to 8.x. Thanks!