What was done :

  • Blocks were removed that can now be added using facetapi-6.x-3.x and apachesolr_sort
  • Some legacy code has been removed and commented out. We should revisit those
  • module is using proper apachesolr-6.x-3.x apis
  • path was changed from /search/apachesolr_search to /search/site

new branch of apachesolr_sort was created so the legacy code in this module could disappear.
Check out the branch apachesolr_sort-6.x-3.x

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Nick_vh’s picture

Status: Active » Needs work
FileSize
6.95 KB
Nick_vh’s picture

Issue tags: +solr, +drupal.org D7
drumm’s picture

Does anything handle redirecting /search/apachesolr_search to /search/site?

I'm guessing the new blocks have to be themed to match Drupal.org?

Nick_vh’s picture

there's no automatic redirect from apachesolr_search to search/site but that might be something a redirect module can handle?

What would be a sensible approach here?

drumm’s picture

Since this is a wildcard redirect, I don't think path_redirect can do it. I'm not eager to install a new module just for this. We can either do a tiny menu callback or put it in our .htaccess. I'd prefer the menu callback since PHP is nicer than Apache config.

Nick_vh’s picture

I'm perfectly ok with a menu callback. Just need to be sure that the http code is a redirect code, so we don't get penalized by crawlers. But perhaps the search paths are already excluded in robots.txt?

Nick_vh’s picture

FileSize
176 bytes

Just posting the latest diff that is currently there.

Nick_vh’s picture

FileSize
7.38 KB
Nick_vh’s picture

Status: Needs work » Needs review
FileSize
8.29 KB

Could someone already commit this patch. We'll do all the following issues in new issue nodes such as #1792104: Handle redirecting /search/apachesolr_search to /search/site

This is to prevent that we end up in monolithic issues and no structure is left

Nick_vh’s picture

Nick_vh’s picture

Status: Needs review » Needs work
+++ b/drupalorg/drupalorg-download.tpl.phpundefined
@@ -54,23 +54,23 @@
+      <li><a href="/project/modules?f[0]=tid:56">Community</a></li>
+      <li><a href="/project/modules?f[0]=tid:61">Event</a></li>

don't use tid here

drumm’s picture

drumm’s picture

I went ahead and committed #10 to 1548064-support-new-apachesolr. Leaving this open for #11.

Nick_vh’s picture

FileSize
21.75 KB

Adding defaults and update/upgrade script

drumm’s picture

Status: Needs work » Needs review
drumm’s picture

Status: Needs review » Needs work

Committed #14 to the branch with some cleanup:

  • Removed CVS $Id:$
  • Removed undoing of some recent commits I'd made
  • Corrected the name of drupalorg_project_update_6302()

Still leaving open for #11.

drumm’s picture

Assigned: Unassigned » drumm

taking this

drumm’s picture

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Adding info about apachesolr_sort

  • Commit 282caa4 on 6.x-3.x, 7.x-3.x, 1548064-support-new-apachesolr, 7.x-3.x-dev authored by Nick_vh, committed by drumm:
    [#1684952] Make drupalorg_search compatible with apachesolr-6.x-3.x
    
  • Commit b0dad47 on 6.x-3.x, 7.x-3.x, 1548064-support-new-apachesolr, 7.x-3.x-dev by drumm:
    Removing feature to be replaced by [#1684952]
    
  • Commit c2ad46e on 6.x-3.x, 7.x-3.x, 1548064-support-new-apachesolr, 7.x-3.x-dev authored by Nick_vh, committed by drumm:
    [#1684952] Adding defaults and update/upgrade script
    
  • Commit f3de3d4 on 6.x-3.x, 7.x-3.x, 1548064-support-new-apachesolr, 7.x-3.x-dev by csevb10:
    Issue #1684952 by nick_vh: minor modification to url passing to keep...