Download & Extend
Issues

Refactor form.js

Posted by nod_ on July 14, 2012 at 9:58pm
Project:Drupal core
Version:8.x-dev
Component:javascript
Category:task
Priority:normal
Assigned:Unassigned
Status:needs work
Issue tags:JavaScript clean-up, Needs JS testing

Issue Summary

Move the summary jQuery plugin to it's own file and clean it up. Currently there is too much binding/unbinding going on.
Take formUpdated out of there and to it's own file while making it better: #1636992: General "changed" warning messages / dirty forms
Put fillUserInfoFromCookie behavior somewhere else maybe?

Replace form.js with 3 files and update the references to the proper file in the rest of the code.

Login or register to post comments

Comments

#1

Posted by Kiphaas7 on September 3, 2012 at 3:19am

BONUS: Investigate if adding basic events and detach makes sense, as described in #1763812: [META] Provide complete attach/detach with basic events.

#2

Posted by nod_ on September 7, 2012 at 2:37am
Issue tags:+Needs JS testing

tag

#3

Posted by rballou on November 21, 2012 at 11:09pm

The following modules use the summary functionality provided by `form.js`:

  • block
  • book
  • comment
  • filter
  • menu
  • node
  • path
  • system

A couple questions regarding how to handle updating their library information:

  1. The block module does not explicitly require the summary functionality (it checks if it exists first and exits if not), should I update that to include it as a dependency?
  2. Most of the modules specify `drupal.form` as a dependency. Is this the same as `core/misc/form.js`?

#4

Posted by nod_ on November 21, 2012 at 11:34pm

1. don't think so, i'd have to dig into but it's a small thing.
2. yes

:)

#5

Posted by rballou on November 22, 2012 at 4:40am
Status:active» needs review

Sweet, figured out how the drupal.form bit worked :)

Anyway, here's an initial patch that: removes the summary jQuery code to it's own file, core/misc/drupal.summary.js; updates the system library info; updates the modules above so that there library info calls include the new file; and changes the bindings in the summary code to on/off calls. I have not rolled out any updates for the other two pieces of form.js code. Also I only added drupal.summary as dependencies, I did not check if they code was using the other functionality and remove drupal.form as needed.

I currently have this code push out to github at: https://github.com/robballou/drupal/tree/8.x-form-js

AttachmentSizeStatusTest resultOperations
1685146-refactor-form-js.patch7.31 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1685146-refactor-form-js.patch. Unable to apply patch. See the log in the details link for more information.View details | Re-test

#6

Posted by nod_ on May 16, 2013 at 5:04am

#5: 1685146-refactor-form-js.patch queued for re-testing.

#7

Posted by System Message on May 16, 2013 at 5:08am
Status:needs review» needs work

The last submitted patch, 1685146-refactor-form-js.patch, failed testing.

nobody click here